From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 5/7] perf report: Sort by sampled cycles percent per block for stdio
Date: Tue, 29 Oct 2019 21:36:38 +0800 [thread overview]
Message-ID: <08921142-6e65-62e3-2a1c-9a78c7bc7d2e@linux.intel.com> (raw)
In-Reply-To: <20191029092747.GH28772@krava>
On 10/29/2019 5:27 PM, Jiri Olsa wrote:
> On Mon, Oct 28, 2019 at 09:33:28AM +0800, Jin Yao wrote:
>
> SNIP
>
>> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
>> index 0e27d6830011..7cf137b0451b 100644
>> --- a/tools/perf/util/hist.c
>> +++ b/tools/perf/util/hist.c
>> @@ -758,6 +758,10 @@ struct hist_entry *hists__add_entry_block(struct hists *hists,
>> struct hist_entry entry = {
>> .block_info = block_info,
>> .hists = hists,
>> + .ms = {
>> + .map = al->map,
>> + .sym = al->sym,
>> + },
>
> this looks like separated fix, if thats the case
> please explain the change and move it to separate patch
>
> thanks,
> jirka
>
Sorry, that should be the obsolete code. Thanks so much for pointing
this out.
Thanks
Jin Yao
next prev parent reply other threads:[~2019-10-29 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 1:33 [PATCH v4 0/7] perf report: Support sorting all blocks by cycles Jin Yao
2019-10-28 1:33 ` [PATCH v4 1/7] perf diff: Don't use hack to skip column length calculation Jin Yao
2019-10-28 1:33 ` [PATCH v4 2/7] perf util: Cleanup and refactor block info functions Jin Yao
2019-10-28 1:33 ` [PATCH v4 3/7] perf util: Count the total cycles of all samples Jin Yao
2019-10-28 1:33 ` [PATCH v4 4/7] perf util: Support block formats with compare/sort/display Jin Yao
2019-10-28 1:33 ` [PATCH v4 5/7] perf report: Sort by sampled cycles percent per block for stdio Jin Yao
2019-10-29 9:27 ` Jiri Olsa
2019-10-29 13:19 ` Jin, Yao
2019-10-29 9:27 ` Jiri Olsa
2019-10-29 13:36 ` Jin, Yao [this message]
2019-10-30 6:08 ` Jin, Yao
2019-10-28 1:33 ` [PATCH v4 6/7] perf report: Support --percent-limit for --total-cycles Jin Yao
2019-10-28 1:33 ` [PATCH v4 7/7] perf report: Sort by sampled cycles percent per block for tui Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08921142-6e65-62e3-2a1c-9a78c7bc7d2e@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).