* [RFC PATCH] gpu: no need to compile drm/ if CONFIG_DRM=n @ 2019-09-11 17:34 Qian Cai [not found] ` <CAO4ZVTMUMKMOqef5yV=5bwHLXLMsNtTegGGMkw0GbFaDHvrV6g@mail.gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Qian Cai @ 2019-09-11 17:34 UTC (permalink / raw) To: airlied, daniel Cc: maarten.lankhorst, mripard, sean, yamada.masahiro, michal.lkml, emil.l.velikov, dri-devel, linux-kbuild, linux-kernel, Qian Cai The commit c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y to always compiling drm/. This restores the behavior, so people don't need to waste time compiling stuff they don't need. Fixes: c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") --- drivers/gpu/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile index f17d01f076c7..a793b9ace34b 100644 --- a/drivers/gpu/Makefile +++ b/drivers/gpu/Makefile @@ -3,5 +3,6 @@ # taken to initialize them in the correct order. Link order is the only way # to ensure this currently. obj-$(CONFIG_TEGRA_HOST1X) += host1x/ -obj-y += drm/ vga/ +obj-$(CONFIG_DRM) += drm/ +obj-y += vga/ obj-$(CONFIG_IMX_IPUV3_CORE) += ipu-v3/ -- 2.20.1 (Apple Git-117) ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <CAO4ZVTMUMKMOqef5yV=5bwHLXLMsNtTegGGMkw0GbFaDHvrV6g@mail.gmail.com>]
* Re: [RFC PATCH] gpu: no need to compile drm/ if CONFIG_DRM=n [not found] ` <CAO4ZVTMUMKMOqef5yV=5bwHLXLMsNtTegGGMkw0GbFaDHvrV6g@mail.gmail.com> @ 2019-09-11 17:41 ` Qian Cai 2019-09-12 0:52 ` Masahiro Yamada 0 siblings, 1 reply; 3+ messages in thread From: Qian Cai @ 2019-09-11 17:41 UTC (permalink / raw) To: Maxime Ripard Cc: airlied, daniel, dri-devel, emil.l.velikov, linux-kbuild, linux-kernel, maarten.lankhorst, michal.lkml, mripard, sean, yamada.masahiro > On Sep 11, 2019, at 1:37 PM, Maxime Ripard <maxime.ripard@anandra.org> wrote: > > Hi, > > Le mer. 11 sept. 2019 à 19:35, Qian Cai <cai@lca.pw> a écrit : > The commit c0e09200dc08 ("drm: reorganise drm tree to be more future > proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y > to always compiling drm/. This restores the behavior, so people don't > need to waste time compiling stuff they don't need. > > Fixes: c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") > > You are missing your signed-off-by That is intentional because this is a RFC patch to gather the feedback as I am no expert in DRM and may miss something important. Once people are happy with it, I plan to send a formal patch with Signed-off-by. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] gpu: no need to compile drm/ if CONFIG_DRM=n 2019-09-11 17:41 ` Qian Cai @ 2019-09-12 0:52 ` Masahiro Yamada 0 siblings, 0 replies; 3+ messages in thread From: Masahiro Yamada @ 2019-09-12 0:52 UTC (permalink / raw) To: Qian Cai Cc: Maxime Ripard, David Airlie, Daniel Vetter, dri-devel, Emil Velikov, Linux Kbuild mailing list, Linux Kernel Mailing List, maarten.lankhorst, Michal Marek, mripard, Sean Paul On Thu, Sep 12, 2019 at 2:41 AM Qian Cai <cai@lca.pw> wrote: > > > > > On Sep 11, 2019, at 1:37 PM, Maxime Ripard <maxime.ripard@anandra.org> wrote: > > > > Hi, > > > > Le mer. 11 sept. 2019 à 19:35, Qian Cai <cai@lca.pw> a écrit : > > The commit c0e09200dc08 ("drm: reorganise drm tree to be more future > > proof.") changed the behavior from only compiling drm/ if CONFIG_DRM=y > > to always compiling drm/. This restores the behavior, so people don't > > need to waste time compiling stuff they don't need. > > > > Fixes: c0e09200dc08 ("drm: reorganise drm tree to be more future proof.") > > > > You are missing your signed-off-by > > That is intentional because this is a RFC patch to gather the feedback as I am no > expert in DRM and may miss something important. > > Once people are happy with it, I plan to send a formal patch with Signed-off-by. > CONFIG_DRM is tristate. Your patch requires everything under drivers/gpu/drm/ modular when CONFIG_DRM=m. At least, drivers/gpu/drm/drm_mipi_dsi.c is built-in only. I guess that is the reason why they use 'obj-y += drm/'. In other words, if you are able to make all the drm code modular, your patch is applicable. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-12 0:53 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-11 17:34 [RFC PATCH] gpu: no need to compile drm/ if CONFIG_DRM=n Qian Cai [not found] ` <CAO4ZVTMUMKMOqef5yV=5bwHLXLMsNtTegGGMkw0GbFaDHvrV6g@mail.gmail.com> 2019-09-11 17:41 ` Qian Cai 2019-09-12 0:52 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).