From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3694ECAAD3 for ; Wed, 14 Sep 2022 15:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbiINPKZ (ORCPT ); Wed, 14 Sep 2022 11:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbiINPKS (ORCPT ); Wed, 14 Sep 2022 11:10:18 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E181EAEE; Wed, 14 Sep 2022 08:10:02 -0700 (PDT) X-UUID: 334dd020c3ed481785648246ba0c86af-20220914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Wki+1jLIoRTZsjo8Z3mQ/p/MgSXkw7RsuI+0KmLXyS8=; b=jd2D1wIo1C38e3AEneUOIPKKFI8bxFPfR+O977nm0fPEtI4nl/V7AVKz/J2fBb4JuGD9blIIdxBSLpySjc5nocUL2yH7H/IfKn1naEbUSPg3yxpf0Nh+i5h3jDXWE4t+35GJLXc79dQudKXz17dOegpsl2Em4PChr8CnHFxCuKI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:5e81eeeb-8faf-401d-9e09-cc1eeb7e4b27,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:45 X-CID-INFO: VERSION:1.1.11,REQID:5e81eeeb-8faf-401d-9e09-cc1eeb7e4b27,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:45 X-CID-META: VersionHash:39a5ff1,CLOUDID:74e6a55d-5ed4-4e28-8b00-66ed9f042fbd,B ulkID:220914223211YQW5MWQ3,BulkQuantity:68,Recheck:0,SF:28|17|19|48,TC:nil ,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL:0 X-UUID: 334dd020c3ed481785648246ba0c86af-20220914 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 707181027; Wed, 14 Sep 2022 23:09:58 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Wed, 14 Sep 2022 23:09:57 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Wed, 14 Sep 2022 23:09:57 +0800 Message-ID: <08a2ca0cd6392dcf9dea98eed50516ed19cc1504.camel@mediatek.com> Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 From: Jason-JH Lin To: Matthias Brugger , Bo-Chen Chen , Krzysztof Kozlowski , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" CC: Nancy Lin =?UTF-8?Q?=28=E6=9E=97=E6=AC=A3=E8=9E=A2=29?= , CK Hu =?UTF-8?Q?=28=E8=83=A1=E4=BF=8A=E5=85=89=29?= , "chunkuang.hu@kernel.org" , "angelogioacchino.delregno@collabora.com" , "hsinyi@google.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Date: Wed, 14 Sep 2022 23:09:56 +0800 In-Reply-To: <463b0b0a-c1ec-0f89-45cf-50a7587db69b@gmail.com> References: <20220825091448.14008-1-rex-bc.chen@mediatek.com> <3ed3d73a-1671-708e-7c42-498cca6aaf1d@gmail.com> <8f3dba943170361211d9bb4c8bf1be12bbfdec20.camel@mediatek.com> <916bd99bcc4fa77eae5734b22365ce73acd90d58.camel@mediatek.com> <463b0b0a-c1ec-0f89-45cf-50a7587db69b@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-09-14 at 16:32 +0200, Matthias Brugger wrote: > > On 26/08/2022 17:39, Matthias Brugger wrote: > > > > > > On 26/08/2022 09:13, Bo-Chen Chen wrote: > > > On Fri, 2022-08-26 at 15:00 +0800, Krzysztof Kozlowski wrote: > > > > On 26/08/2022 05:07, Bo-Chen Chen wrote: > > > > > On Thu, 2022-08-25 at 22:57 +0800, Matthias Brugger wrote: > > > > > > > > > > > > On 25/08/2022 11:14, Bo-Chen Chen wrote: > > > > > > > From: "Jason-JH.Lin" > > > > > > > > > > > > > > For previous MediaTek SoCs, such as MT8173, there are 2 > > > > > > > display > > > > > > > HW > > > > > > > pipelines binding to 1 mmsys with the same power domain, > > > > > > > the > > > > > > > same > > > > > > > clock driver and the same mediatek-drm driver. > > > > > > > > > > > > > > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW > > > > > > > pipelines > > > > > > > binding > > > > > > > to > > > > > > > 2 different power domains, different clock drivers and > > > > > > > different > > > > > > > mediatek-drm drivers. > > > > > > > > > > > > > > Moreover, Hardware pipeline of VDOSYS0 has these > > > > > > > components: > > > > > > > COLOR, > > > > > > > CCORR, AAL, GAMMA, DITHER. They are related to the PQ > > > > > > > (Picture > > > > > > > Quality) > > > > > > > and they makes VDOSYS0 supports PQ function while they > > > > > > > are not > > > > > > > including in VDOSYS1. > > > > > > > > > > > > > > Hardware pipeline of VDOSYS1 has the component ETHDR (HDR > > > > > > > related > > > > > > > component). It makes VDOSYS1 supports the HDR function > > > > > > > while > > > > > > > it's > > > > > > > not > > > > > > > including in VDOSYS0. > > > > > > > > > > > > > > To summarize0: > > > > > > > Only VDOSYS0 can support PQ adjustment. > > > > > > > Only VDOSYS1 can support HDR adjustment. > > > > > > > > > > > > > > Therefore, we need to separate these two different mmsys > > > > > > > hardwares > > > > > > > to > > > > > > > 2 different compatibles for MT8195. > > > > > > > > > > > > > > Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: > > > > > > > add > > > > > > > mt8195 > > > > > > > SoC binding") > > > > > > > Signed-off-by: Jason-JH.Lin > > > > > > > Signed-off-by: Bo-Chen Chen > > > > > > > --- > > > > > > > Changes for v2: > > > > > > > 1. Add hardware difference for VDOSYS0 and VDOSYS1 in > > > > > > > commit > > > > > > > message. > > > > > > > --- > > > > > > > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > > > > > > > > > > > > > > > > > > > > > > 3 ++- > > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git > > > > > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek > > > > > > > ,mmsys > > > > > > > .yam > > > > > > > l > > > > > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek > > > > > > > ,mmsys > > > > > > > .yam > > > > > > > l > > > > > > > index 6ad023eec193..bfbdd30d2092 100644 > > > > > > > --- > > > > > > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek > > > > > > > ,mmsys > > > > > > > .yam > > > > > > > l > > > > > > > +++ > > > > > > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek > > > > > > > ,mmsys > > > > > > > .yam > > > > > > > l > > > > > > > @@ -31,7 +31,8 @@ properties: > > > > > > > - mediatek,mt8183-mmsys > > > > > > > - mediatek,mt8186-mmsys > > > > > > > - mediatek,mt8192-mmsys > > > > > > > - - mediatek,mt8195-mmsys > > > > > > > + - mediatek,mt8195-vdosys0 > > > > > > > > > > > > Thanks for you patch. As I mentioned on v1, I propose to > > > > > > set > > > > > > mediatek,mt8195-mmsys as fallback for mediatek,mt8195- > > > > > > vdosys0 to > > > > > > not > > > > > > break > > > > > > backwards compatibility. > > > > > > > > > > > > Apart from that, the binding change will need some changes > > > > > > to > > > > > > support > > > > > > the new > > > > > > binding. Please provide these together with this patch. > > > > > > > > > > > > Regards, > > > > > > Matthias > > > > > > > > > > > > > > > > Hello Matthias, > > > > > > > > > > Thanks for your comments. > > > > > The purpose of this patch is to confirm we can separate > > > > > mt8195 > > > > > mmsys > > > > > into two compatibles. I think this modification is accepted. > > > > > > > > No, it is not accepted following Matthias comments. You > > > > received my > > > > ack > > > > based on assumption that ABI break is perfectly ok for platform > > > > maintainer, as he has decisive voice. If anyone is not happy > > > > with a > > > > ABI > > > > break, then his concerns must be addressed. > > > > > > > > So let it be specific: > > > > NAK. > > > > > > > > > > > > > > After this, I think Jason-JH will push another series with > > > > > this > > > > > binding > > > > > patch. > > > > > > > > I don't know what do you mean here - another series on top of > > > > wrong > > > > patch? > > > > > > > > > > Hello Krzysztof, > > > > > > For this mt8195 mmsys binding separation, we still need to modify > > > driver for this. The reason I send this patch is to confirm we > > > can do > > > this binding modification and I also think we can not pick this > > > patch > > > here. > > > > > > We will push another series and it contains modification of > > > binding and > > > drivers. (The series will push by Jason-JH Lin) > > > > > > > Sounds good. So lets wait for Jason-JH Lin to send this series and > > we can go on > > with the review. > > > > Just to be sure, this has not happened yet, correct? > > Regards, > Matthias Yes, sorry for the late reply to you. I'll start to send this series at 9/19. Regards, Jason-JH.Lin > > > Thanks! > > Matthias > > > > > Maybe I should use "RFC" for this series, and I think it's more > > > correct. > > > > > > BRs, > > > Bo-Chen > > > > > > > > In Jason-JH's series, we will modify mmsys driver based on > > > > > this. > > > > > And I think we don't need to keep "mediatek,mt8195-mmsys" if > > > > > we > > > > > also > > > > > modify mmsys drivers in the same series. > > > > > > > > This does not fux ABI break and broken bisectability. > > > > > > > > > > > > > > Is it ok that postpones to pick this patch until we finish > > > > > review > > > > > follow-up series? > > > > > > > > > > > > > No. You got a clear review to fix. > > > > > > > > Best regards, > > > > Krzysztof -- Jason-JH Lin