From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59947C433FE for ; Mon, 1 Nov 2021 11:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BE45610A8 for ; Mon, 1 Nov 2021 11:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbhKALfG (ORCPT ); Mon, 1 Nov 2021 07:35:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35132 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232199AbhKALfE (ORCPT ); Mon, 1 Nov 2021 07:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635766351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RYc7kj3KhIC57+jtFXvlpfVC9ikhX2Z8kNJ8F2TK81c=; b=Fxu5BRJFoWrYxkbX2c/hJUARld2Nrq0mq/cbUcl430moe376S784qVHPdP/yztXDYyq2nn BIrStXj1M7PETJjrff1mbLCb8LPmYsBXm2cggujUyRZt/xubByNc6JXNhxuh11LifkdXaN 50o2VaeWc6866QMCql33EzzKKDrLFEY= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-I4jgVMzxPwG3gFphONLOLw-1; Mon, 01 Nov 2021 07:32:00 -0400 X-MC-Unique: I4jgVMzxPwG3gFphONLOLw-1 Received: by mail-ed1-f72.google.com with SMTP id y20-20020a056402359400b003e28c9bc02cso2282786edc.9 for ; Mon, 01 Nov 2021 04:32:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RYc7kj3KhIC57+jtFXvlpfVC9ikhX2Z8kNJ8F2TK81c=; b=xSh7f411CW2sL70+M5as7hiZbQ+zIFuIMofXkTVCd89fynlpIAHnRsdHyjQ5jvCDYI aUPbNtmYXFZPsrxC0getK/3ly9tqVzpPsYHpmmUc7n81zGtLLcjPhCKHXCL9IXVf7znA DPytPh1G1i87t/p4Sp04E4KXwWExoMyqmWxR/ppKtRKkUpb7tObpgbdwipjDpBc07ecz VgmP0dMHRkNM495KlmKR34giWztqhMCBeY274407pqh9h3O8Erzx5pD0ZHmyRfHCNc4N R3ZHnJYJOb1Tqt/jmOeXb/fNIsKanjmusgiiXP7HbDeIWF5JRp5EGKzlST0/vlbocRNR 7xuw== X-Gm-Message-State: AOAM533jO/I8ojw0SAynxGG3tRiEqUPuTc1AvkflwgJjSQV2pgDWYYPf AR/9+77rM5H2tKHdPxEO2ddtpNx41AjYgt+BDnfcBuM77pY0puBKS/3Uxi4QcUhSV3Wb9v5fKaG Uq4V4PjsuF99lsclmj5OQGJNc X-Received: by 2002:a05:6402:2743:: with SMTP id z3mr2848031edd.167.1635766319106; Mon, 01 Nov 2021 04:31:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdzg3VeYKOvszAqY+bqfDsMTo43Ia8gPNjqW9LqNEBZ2jGBaPHdiCf4pqPe8/QslsQIofAZg== X-Received: by 2002:a05:6402:2743:: with SMTP id z3mr2848008edd.167.1635766318947; Mon, 01 Nov 2021 04:31:58 -0700 (PDT) Received: from [10.40.1.223] ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id hb14sm2906657ejc.115.2021.11.01.04.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 04:31:58 -0700 (PDT) Message-ID: <08a94895-ad57-c8f2-fcb5-ff1c1637dc0d@redhat.com> Date: Mon, 1 Nov 2021 12:31:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell Content-Language: en-US To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Mark Gross , Andy Shevchenko , Wolfram Sang , Mika Westerberg , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Len Brown , ACPI Devel Maling List , Platform Driver , Linux Kernel Mailing List , linux-i2c , Sakari Ailus , Kate Hsuan , Linux Media Mailing List , linux-clk References: <20211025094119.82967-1-hdegoede@redhat.com> <20211025094119.82967-11-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/25/21 13:38, Andy Shevchenko wrote: > On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede wrote: >> >> Pass tps68470_regulator_platform_data to the tps68470-regulator >> MFD-cell, specifying the voltages of the various regulators and >> tying the regulators to the sensor supplies so that sensors which use >> the TPS68470 can find their regulators. >> >> Since the voltages and supply connections are board-specific, this >> introduces a DMI matches int3472_tps68470_board_data struct which >> contains the necessary per-board info. >> >> This per-board info also includes GPIO lookup information for the >> sensor GPIOs which may be connected to the tps68470 gpios. > > gpios --> GPIO lines Fixed for v5. > ... > >> + board_data = int3472_tps68470_get_board_data(dev_name(&client->dev)); > >> + if (board_data) > > IIRC it's a dup. Below already incorporates this. > >> + gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_table); Not sure what you mean here? This line *dereferences* board_data, so even if gpiod_remove_lookup_table() already contains a NULL check for the table pointer, we still need the board_data check to avoid dereferencing it to get the tps68470_gpio_lookup_table member. Regards, Hans