From: "Andrew Jeffery" <andrew@aj.id.au>
To: openipmi-developer@lists.sourceforge.net,
"Corey Minyard" <minyard@acm.org>
Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ipmi: kcs: Poll OBF briefly to reduce OBE latency
Date: Thu, 06 Oct 2022 09:42:57 +1030 [thread overview]
Message-ID: <08c20621-e75d-4a72-82e6-b1980304e20a@app.fastmail.com> (raw)
In-Reply-To: <20220812144741.240315-1-andrew@aj.id.au>
Hi Corey,
On Sat, 13 Aug 2022, at 00:17, Andrew Jeffery wrote:
> The ASPEED KCS devices don't provide a BMC-side interrupt for the host
> reading the output data register (ODR). The act of the host reading ODR
> clears the output buffer full (OBF) flag in the status register (STR),
> informing the BMC it can transmit a subsequent byte.
>
> On the BMC side the KCS client must enable the OBE event *and* perform a
> subsequent read of STR anyway to avoid races - the polling provides a
> window for the host to read ODR if data was freshly written while
> minimising BMC-side latency.
Just wondering whether you're happy to pick this one up? I haven't seen
it hit the IPMI tree yet.
Cheers,
Andrew
next prev parent reply other threads:[~2022-10-05 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 14:47 [PATCH] ipmi: kcs: Poll OBF briefly to reduce OBE latency Andrew Jeffery
2022-10-05 23:12 ` Andrew Jeffery [this message]
2022-10-05 23:54 ` Corey Minyard
2022-10-06 3:08 ` Andrew Jeffery
2022-10-05 23:50 ` Joel Stanley
2022-10-06 3:06 ` Andrew Jeffery
2022-10-06 14:09 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08c20621-e75d-4a72-82e6-b1980304e20a@app.fastmail.com \
--to=andrew@aj.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).