From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC2FC433FE for ; Thu, 29 Sep 2022 13:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235457AbiI2N0e (ORCPT ); Thu, 29 Sep 2022 09:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235680AbiI2N0M (ORCPT ); Thu, 29 Sep 2022 09:26:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 995491166CD for ; Thu, 29 Sep 2022 06:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664457968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cRppPu8Rg7//eJDTidhVUrVedsDey7PezTpFqKhKxns=; b=hzojHKfjRpQVRfYybtqy2eUFC3yjiEpOvGIkNJFu/MwCxkj8rEj8RHeERF1Of4KP6KU02n H7FE6KOAuZw9Yq6W7rkxLZJI9scrWeARTXOSB8mNXzkpD64Lj1FJWPfAvJQIf+5Aga/dzU XPWe3xozmNEGTIqcxHioUO3rsIL2mkg= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-82-A5RBGA43MNeIsTP94Hb4SA-1; Thu, 29 Sep 2022 09:26:06 -0400 X-MC-Unique: A5RBGA43MNeIsTP94Hb4SA-1 Received: by mail-ed1-f72.google.com with SMTP id c6-20020a05640227c600b004521382116dso1287653ede.22 for ; Thu, 29 Sep 2022 06:26:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=cRppPu8Rg7//eJDTidhVUrVedsDey7PezTpFqKhKxns=; b=8PFAg7qZG9SvECjQfygn7vshmcOH503BYuoY3Rmt8duoX7Ywh6cknyHKNQxwtSUdZ5 wwNo9fWfTNMoOwO5IERuynWth0u3o280miK9HcMkmkwaOyA80CVdW5CudmkK7ILagYd1 dgjV2mKmJ96wdUgZ2Hx5Na/phK25mmHzIOwD1jIKi2CVcYMw/+rUmVbv/deRzphqjbLg XauEJDaD/trMO57+698yk6AhgNAAHVuE43+2CMOrtOUl6nhlzOcg4QMezjtbIva+Ekx7 DnUbBznGs7XxK/L6vpU7c10FpXFGxLto2K9Os1sT1ZnILH5gaveSV+2r0NLf/Xl/EzyL r21w== X-Gm-Message-State: ACrzQf2NHIQDyRHm9WKd8MpDryx9vfgclugzRSaPSvjY5ZTcqtQHXeIe +f6eFBH7rZm/bP67larSQnmnCNljYpdNkh1vlAdBO+Hx6dfPTF2frl7UTyFnXbCln/W3MCZ6q0a Ae3k0z9FTMXWa6YmOBCg8xbP7 X-Received: by 2002:a05:6402:1d48:b0:458:f29:798 with SMTP id dz8-20020a0564021d4800b004580f290798mr3412043edb.414.1664457965607; Thu, 29 Sep 2022 06:26:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6m8ao/iBqJiTNgnUSG4lrRSPkOqbc3kShCZLMMNEpN8r9K6AkDxDEWTvQTjWe/qBTI7PveRw== X-Received: by 2002:a05:6402:1d48:b0:458:f29:798 with SMTP id dz8-20020a0564021d4800b004580f290798mr3412018edb.414.1664457965335; Thu, 29 Sep 2022 06:26:05 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id r17-20020a17090609d100b00781d411a63csm3948244eje.151.2022.09.29.06.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 06:26:04 -0700 (PDT) Message-ID: <08dab49f-9ca4-4978-4482-1815cf168e74@redhat.com> Date: Thu, 29 Sep 2022 15:26:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN To: Sean Christopherson , Maxim Levitsky Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20220926165112.603078-1-pbonzini@redhat.com> <15291c3f-d55c-a206-9261-253a1a33dce1@redhat.com> Content-Language: en-US From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/28/22 19:55, Sean Christopherson wrote: >> As far as my opinion goes I do volunteer to test this code more often, >> and I do not want to see the 32 bit KVM support be removed*yet*. > > Yeah, I 100% agree that it shouldn't be removed until we have equivalent test > coverage. But I do think it should an "off-by-default" sort of thing. Maybe > BROKEN is the wrong dependency though? E.g. would EXPERT be a better option? Yeah, maybe EXPERT is better but I'm not sure of the equivalent test coverage. 32-bit VMX/SVM kvm-unit-tests are surely a good idea, but what's wrong with booting an older guest? Paolo