From: Khalid Aziz <khalid@gonehiking.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/8] scsi: BusLogic: Supply __printf(x, y) formatting for blogic_msg()
Date: Wed, 17 Mar 2021 11:01:30 -0600 [thread overview]
Message-ID: <08dddf10-d020-93ae-3783-2a911ff88f42@gonehiking.org> (raw)
In-Reply-To: <20210317091125.2910058-2-lee.jones@linaro.org>
On 3/17/21 3:11 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/scsi/BusLogic.c:51:
> drivers/scsi/BusLogic.c: In function ‘blogic_msg’:
> drivers/scsi/BusLogic.c:3591:2: warning: function ‘blogic_msg’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
>
> Cc: Khalid Aziz <khalid@gonehiking.org>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/scsi/BusLogic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index ccb061ab0a0ad..0ac3f713fc212 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -3578,7 +3578,7 @@ Target Requested Completed Requested Completed Requested Completed\n\
> /*
> blogic_msg prints Driver Messages.
> */
> -
> +__printf(2, 4)
> static void blogic_msg(enum blogic_msglevel msglevel, char *fmt,
> struct blogic_adapter *adapter, ...)
> {
>
Acked-by: Khalid Aziz <khalid@gonehiking.org>
next prev parent reply other threads:[~2021-03-17 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:11 [PATCH 0/8] [Set 3 v2] Rid W=1 warnings in SCSI Lee Jones
2021-03-17 9:11 ` [PATCH 1/8] scsi: BusLogic: Supply __printf(x, y) formatting for blogic_msg() Lee Jones
2021-03-17 17:01 ` Khalid Aziz [this message]
2021-03-17 9:11 ` [PATCH 2/8] scsi: nsp32: Supply __printf(x, y) formatting for nsp32_message() Lee Jones
2021-03-17 9:11 ` [PATCH 3/8] scsi: nsp32: Remove or exclude unused variables Lee Jones
2021-03-17 9:11 ` [PATCH 4/8] scsi: FlashPoint: Remove unused variable 'TID' from 'FlashPoint_AbortCCB()' Lee Jones
2021-03-17 17:02 ` Khalid Aziz
2021-03-17 9:11 ` [PATCH 5/8] scsi: sim710: Remove unused variable 'err' from sim710_init() Lee Jones
2021-03-17 9:11 ` [PATCH 6/8] scsi: isci: remote_device: Make local function isci_remote_device_wait_for_resume_from_abort() static Lee Jones
2021-03-17 9:11 ` [PATCH 7/8] scsi: isci: port: Make local function 'port_state_name()' static Lee Jones
2021-03-17 9:11 ` [PATCH 8/8] scsi: nsp32: Correct expected types in debug print formatting Lee Jones
2021-03-19 2:58 ` [PATCH 0/8] [Set 3 v2] Rid W=1 warnings in SCSI Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08dddf10-d020-93ae-3783-2a911ff88f42@gonehiking.org \
--to=khalid@gonehiking.org \
--cc=jejb@linux.ibm.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).