From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"Bart Tanghe" <bart.tanghe@thomasmore.be>,
"Scott Branden" <sbranden@broadcom.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ray Jui" <rjui@broadcom.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] pwm: bcm2835: Dynamically allocate base
Date: Tue, 04 Feb 2020 10:17:43 +0100 [thread overview]
Message-ID: <08e2b640f0a7713d905295fc4f75df49617be6c1.camel@suse.de> (raw)
In-Reply-To: <20200203213536.32226-1-f.fainelli@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Mon, 2020-02-03 at 13:35 -0800, Florian Fainelli wrote:
> The newer 2711 and 7211 chips have two PWM controllers and failure to
> dynamically allocate the PWM base would prevent the second PWM
> controller instance being probed for succeeding with an -EEXIST error
> from alloc_pwms().
>
> Fixes: e5a06dc5ac1f ("pwm: Add BCM2835 PWM driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> drivers/pwm/pwm-bcm2835.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
> index 91e24f01b54e..d78f86f8e462 100644
> --- a/drivers/pwm/pwm-bcm2835.c
> +++ b/drivers/pwm/pwm-bcm2835.c
> @@ -166,6 +166,7 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
>
> pc->chip.dev = &pdev->dev;
> pc->chip.ops = &bcm2835_pwm_ops;
> + pc->chip.base = -1;
> pc->chip.npwm = 2;
> pc->chip.of_xlate = of_pwm_xlate_with_flags;
> pc->chip.of_pwm_n_cells = 3;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-04 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 21:35 [PATCH] pwm: bcm2835: Dynamically allocate base Florian Fainelli
2020-02-04 6:46 ` Uwe Kleine-König
2020-02-04 9:17 ` Nicolas Saenz Julienne [this message]
2020-02-20 19:14 ` Florian Fainelli
2020-02-20 21:07 ` Uwe Kleine-König
2020-03-13 17:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e2b640f0a7713d905295fc4f75df49617be6c1.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bart.tanghe@thomasmore.be \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).