From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7EEC4742C for ; Thu, 5 Nov 2020 14:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0E532071A for ; Thu, 5 Nov 2020 14:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730906AbgKEOOD (ORCPT ); Thu, 5 Nov 2020 09:14:03 -0500 Received: from foss.arm.com ([217.140.110.172]:33706 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbgKEOOD (ORCPT ); Thu, 5 Nov 2020 09:14:03 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 894BA14BF; Thu, 5 Nov 2020 06:14:02 -0800 (PST) Received: from [10.37.12.41] (unknown [10.37.12.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C55673F719; Thu, 5 Nov 2020 06:13:59 -0800 (PST) Subject: Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML References: <5e3c76cac4b161fe39e3fc8ace614400bc2fb5b1.1604531793.git.andreyknvl@google.com> <58aae616-f1be-d626-de16-af48cc2512b0@arm.com> <1ef3f645-8b91-cfcf-811e-85123fea90fa@arm.com> From: Vincenzo Frascino Message-ID: <090ab218-8566-772b-648f-00001413fef2@arm.com> Date: Thu, 5 Nov 2020 14:17:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/20 12:14 PM, Andrey Konovalov wrote: > On Thu, Nov 5, 2020 at 12:39 PM Vincenzo Frascino > wrote: >> >> On 11/5/20 11:35 AM, Andrey Konovalov wrote: >>> This will work. Any preference on the name of this function? >>> >> >> I called it in my current iteration mte_enable(), and calling it from >> cpu_enable_mte(). >> >>> Alternatively we can rename mte_init_tags() to something else and let >>> it handle both RRND and sync/async. >> >> This is an option but then you need to change the name of kasan_init_tags and >> the init_tags indirection name as well. I would go for the simpler and just >> splitting the function as per above. >> >> What do you think? > > OK, let's split. mte_enable() as a name sounds good to me. Both > functions will still be called one right after another from > kasan_init_hw_tags (as it's now called) though. I think the name > works, as it means initializing the hw_tags mode, not just the tags. > I agree. When you finish with v9, could you please provide a tree with both the sets on top similar to [1]? I would like to repeat the tests (ltp + kselftests) and even to rebase my async code on top of it since we are aligning with the development. [1] https://github.com/xairy/linux/tree/up-boot-mte-v1 > Will do in v9. > -- Regards, Vincenzo