From: Roger Lu <roger.lu@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
"Kevin Hilman" <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"Nicolas Boichat" <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
YT Lee <yt.lee@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v19 3/7] soc: mediatek: SVS: introduce MTK SVS engine
Date: Fri, 2 Jul 2021 17:19:06 +0800 [thread overview]
Message-ID: <0911434c39aa76a6312f19baa2a468c65589de3d.camel@mediatek.com> (raw)
In-Reply-To: <bf4f26cdca7174ba687e29a581a5276511112fe7.camel@pengutronix.de>
Hi Philipp,
Thanks for the advice.
On Fri, 2021-07-02 at 10:33 +0200, Philipp Zabel wrote:
> Hi Roger,
>
> On Fri, 2021-07-02 at 11:12 +0800, Roger Lu wrote:
> [...]
> > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> > new file mode 100644
> > index 000000000000..c2fcbc204b1d
> > --- /dev/null
> > +++ b/drivers/soc/mediatek/mtk-svs.c
> > @@ -0,0 +1,1724 @@
>
> [...]
> > +static int svs_suspend(struct device *dev)
> > +{
> > + struct svs_platform *svsp = dev_get_drvdata(dev);
> > + struct svs_bank *svsb;
> > + unsigned long flags;
> > + int ret;
> > + u32 idx;
> > +
> > + for (idx = 0; idx < svsp->bank_num; idx++) {
> > + svsb = &svsp->banks[idx];
> > +
> > + /* Wait if svs_isr() is still in process. */
> > + spin_lock_irqsave(&mtk_svs_lock, flags);
> > + svsp->pbank = svsb;
> > + svs_switch_bank(svsp);
> > + svs_writel(svsp, SVSB_EN_OFF, SVSEN);
> > + svs_writel(svsp, SVSB_INTSTS_CLEAN, INTSTS);
> > + spin_unlock_irqrestore(&mtk_svs_lock, flags);
> > +
> > + svsb->suspended = true;
> > + if (svsb->phase != SVSB_PHASE_INIT01) {
> > + svsb->phase = SVSB_PHASE_ERROR;
> > + svs_adjust_pm_opp_volts(svsb, true);
> > + }
> > + }
> > +
> > + if (svsp->rst) {
>
> This is not necessary, reset_control_assert() checks for (rstc == NULL)
> itself.
Okay. We'll remove "if (svsp->rst) {" in the next patch. Thanks.
>
> > + ret = reset_control_assert(svsp->rst);
> > + if (ret) {
> > + dev_err(svsp->dev, "cannot assert reset %d\n", ret);
> > + return ret;
> > + }
> > + }
> > +
> > + clk_disable_unprepare(svsp->main_clk);
> > +
> > + return 0;
> > +}
> > +
> > +static int svs_resume(struct device *dev)
> > +{
> > + struct svs_platform *svsp = dev_get_drvdata(dev);
> > + struct svs_bank *svsb;
> > + int ret;
> > + u32 idx;
> > +
> > + ret = clk_prepare_enable(svsp->main_clk);
> > + if (ret) {
> > + dev_err(svsp->dev, "cannot enable main_clk, disable svs\n");
> > + return ret;
> > + }
> > +
> > + if (svsp->rst) {
>
> Same as above, reset_control_deassert(NULL) will just return 0.
Okay. We'll remove "if (svsp->rst) {" in the next patch. Thanks.
>
> > + ret = reset_control_deassert(svsp->rst);
> > + if (ret) {
> > + dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
> > + return ret;
> > + }
> > + }
> > +
> > + for (idx = 0; idx < svsp->bank_num; idx++) {
> > + svsb = &svsp->banks[idx];
> > + svsb->suspended = false;
> > + }
> > +
> > + ret = svs_init02(svsp);
> > + if (ret)
> > + return ret;
> > +
> > + svs_mon_mode(svsp);
> > +
> > + return 0;
> > +}
>
> regards
> Philipp
next prev parent reply other threads:[~2021-07-02 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 3:12 [PATCH v19 0/7] soc: mediatek: SVS: introduce MTK SVS Roger Lu
2021-07-02 3:12 ` [PATCH v19 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings Roger Lu
2021-07-02 3:12 ` [PATCH v19 2/7] arm64: dts: mt8183: add svs device information Roger Lu
2021-07-02 3:12 ` [PATCH v19 3/7] soc: mediatek: SVS: introduce MTK SVS engine Roger Lu
2021-07-02 8:33 ` Philipp Zabel
2021-07-02 9:19 ` Roger Lu [this message]
2021-07-02 3:12 ` [PATCH v19 4/7] soc: mediatek: SVS: add debug commands Roger Lu
2021-07-02 3:12 ` [PATCH v19 5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings Roger Lu
2021-07-02 3:12 ` [PATCH v19 6/7] arm64: dts: mt8192: add svs device information Roger Lu
2021-07-02 3:12 ` [PATCH v19 7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver Roger Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0911434c39aa76a6312f19baa2a468c65589de3d.camel@mediatek.com \
--to=roger.lu@mediatek.com \
--cc=Angus.Lin@mediatek.com \
--cc=Charles.Yang@mediatek.com \
--cc=HenryC.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Xiaoqing.Liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=yt.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).