From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D36C4332F for ; Wed, 11 May 2022 08:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243430AbiEKIP4 (ORCPT ); Wed, 11 May 2022 04:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243420AbiEKIPv (ORCPT ); Wed, 11 May 2022 04:15:51 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB24E19284 for ; Wed, 11 May 2022 01:15:47 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id be20so1527364edb.12 for ; Wed, 11 May 2022 01:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nGIPkUoD0VqgRPwmnJdq8aDIQ4mHp9cW//PkaS4eSJQ=; b=v12qa2iTtKx2vdf1vq2PcT9u9GdQ9m9IGKZ4JZ6rG21TQSTvTP4+nmoa9IUpXFBIoo HCXVmFpF11W8kT0P0Be2LQsxp0UEhAcGedjF+gxrswebMy203EvQsuk8q9cnpCIwnDHi hJ8YVa+U5r+jDrQcUeQyDMH67V3MZoI5Ar2zEYMN0FPeklwVUvkTKQfUo/4ly7GB06wU kRRQ0tUqRQcD2ivSDskqB0eOB4fmz9yDyMBGd1Csf8zg4FUVHmZ/jQT1fE9dUvLCxZsg 7028VOdrs3AVEHGFcTMMi93816g4PU0rULHhSquz166SszX/Cdl+dslpk2QRxW58Y67l 4Kvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nGIPkUoD0VqgRPwmnJdq8aDIQ4mHp9cW//PkaS4eSJQ=; b=3GEkDbCI/OilH20xOmcSkiUAsHvuX5hEV2YFxx7X/cdxHqTnWLvZqYMyA3Gtl0kWKq wTzUfSXJ1OJ0OhwQScGWzb2v4+3iXKAYaxSBAVuGCCGk0zBqDxwzvciW+93q13lmk8cK bU2AC+YSCplZ7ROBd6IVOXnyeQSe2xmMG6NVLMf6mya6VdL20WUFbTleJQDXMNz1jrZA FZCzlvg74GE27v7rMeIPJW5hk60ERNuZZRWwycSNrsNxC7uv9FeZtErAx24ZyWhrlAoA zMTK1rxA4Za/COTO+Zps0HMPGl6d9EEauOL6s3X0bVbv+MBBx0C+/oqcF6Op+v6ohevy /1zw== X-Gm-Message-State: AOAM530kA2978aEetusiVP0RTMXDemYLt2G3pMBVr8aildAG/uCJT7f0 2ZdvaKzWFrgRfz22AgUIz698rA== X-Google-Smtp-Source: ABdhPJyYpUvmHj5wexeKIFtMMhSwQ6w/vOEaR6DABNPdZPWdmBPuhvXzbQ4nDmBN1Iq3dFKuJCdiuw== X-Received: by 2002:aa7:c31a:0:b0:425:df3c:de8e with SMTP id l26-20020aa7c31a000000b00425df3cde8emr27001921edq.83.1652256946337; Wed, 11 May 2022 01:15:46 -0700 (PDT) Received: from [192.168.0.254] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id n15-20020a05640204cf00b0042617ba63c4sm782288edw.78.2022.05.11.01.15.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 01:15:45 -0700 (PDT) Message-ID: <091e6619-3341-4a98-90f6-48a6281f6275@linaro.org> Date: Wed, 11 May 2022 10:15:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings documentation Content-Language: en-US To: "J, KEERTHY" , robh+dt@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, amitk@kernel.org, kristo@kernel.org, vigneshr@ti.com Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220427064635.24898-1-j-keerthy@ti.com> <20220427064635.24898-2-j-keerthy@ti.com> <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com> <117f175f-62d1-17b5-742b-bcb250b7866f@ti.com> From: Krzysztof Kozlowski In-Reply-To: <117f175f-62d1-17b5-742b-bcb250b7866f@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05/2022 09:53, J, KEERTHY wrote: >>> >>> Any comments on this version? >> >> You got Rob's review, so you don't need also mine. >> >> If you want, then in general look okay, except the description for "reg" >> you could split per items: >> >> reg: >> items: >> - description: VTM cfg1 register space >> - description: VTM cfg2 register space >> - description: efuse register space >> >> It's more obvious what items you expect. > > Hi Krzysztof, > > DTEX > Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts > Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml: found > duplicate key "description" with value "VTM cfg2 register space" > (original value: "VTM cfg1 register space") > Documentation/devicetree/bindings/Makefile:26: recipe for target > 'Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts' > failed > make[1]: *** > [Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts] Er > > I believe multiple instances of description is failing. So can i keep > the description as is? It looks weird. Can you share your code (pastebin/github/paste here)? Best regards, Krzysztof