From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: <vinod.koul@intel.com>, <dan.j.williams@intel.com>,
Tony Lindgren <tony@atomide.com>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<arnd@arndb.de>
Subject: Re: [PATCH 2/2] dmaengine: omap-dma: Support for slave devices with data port window
Date: Mon, 14 Nov 2016 13:56:30 +0200 [thread overview]
Message-ID: <091f6dce-b1d7-6527-b8c6-147becfd8856@ti.com> (raw)
In-Reply-To: <20161114105313.GB23750@n2100.armlinux.org.uk>
On 11/14/2016 12:53 PM, Russell King - ARM Linux wrote:
> On Tue, Oct 25, 2016 at 01:50:19PM +0300, Peter Ujfalusi wrote:
>> Based on the src/dst_port_window_size - if it is set - configure the DMA
>> channel to use double indexing in order to be able to loop within the
>> address window.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> drivers/dma/omap-dma.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
>> 1 file changed, 43 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
>> index 025f499cb20d..29350f936154 100644
>> --- a/drivers/dma/omap-dma.c
>> +++ b/drivers/dma/omap-dma.c
>> @@ -166,6 +166,9 @@ enum {
>> CSDP_DST_BURST_16 = 1 << 14,
>> CSDP_DST_BURST_32 = 2 << 14,
>> CSDP_DST_BURST_64 = 3 << 14,
>> + CSDP_WRITE_NON_POSTED = (0 << 16),
>> + CSDP_WRITE_POSTED = (1 << 16),
>> + CSDP_WRITE_LAST_NON_POSTED = (2 << 16),
>
> Why the useless parens?
I will get rid of them.
>
>> + if (port_window) {
>> + d->ccr |= CCR_SRC_AMODE_DBLIDX;
>> + d->ei = 1;
>> + d->fi = (-1) * (port_window - 1);
>
> You know that's 1 - port_window, or -(port_window - 1).
Yes, I know. "-(port_window - 1)" might be a bit better.
>
>> +
>> + if (port_window / 64)
>> + d->csdp = CSDP_SRC_BURST_64 | CSDP_SRC_PACKED;
>> + else if (port_window / 32)
>> + d->csdp = CSDP_SRC_BURST_32 | CSDP_SRC_PACKED;
>> + else if (port_window / 16)
>> + d->csdp = CSDP_SRC_BURST_16 | CSDP_SRC_PACKED;
>
> Why these divisions? Wouldn't >= be more suitable here? Do they even
> make sense here?
I'll revisit these.
>
>> + } else {
>> + d->ccr |= CCR_SRC_AMODE_CONSTANT;
>> + }
>> } else {
>> - d->ccr |= CCR_DST_AMODE_CONSTANT | CCR_SRC_AMODE_POSTINC;
>> d->csdp = CSDP_SRC_BURST_64 | CSDP_SRC_PACKED;
>> +
>> + d->ccr |= CCR_SRC_AMODE_POSTINC;
>> + if (port_window) {
>> + d->ccr |= CCR_DST_AMODE_DBLIDX;
>> +
>> + if (port_window / 64)
>> + d->csdp = CSDP_DST_BURST_64 | CSDP_DST_PACKED;
>> + else if (port_window / 32)
>> + d->csdp = CSDP_DST_BURST_32 | CSDP_DST_PACKED;
>> + else if (port_window / 16)
>> + d->csdp = CSDP_DST_BURST_16 | CSDP_DST_PACKED;
>
> Ditto.
>
>> + } else {
>> + d->ccr |= CCR_DST_AMODE_CONSTANT;
>> + }
>> }
>>
>> d->cicr = CICR_DROP_IE | CICR_BLOCK_IE;
>> @@ -945,6 +979,9 @@ static struct dma_async_tx_descriptor
*omap_dma_prep_slave_sg(
>> d->ccr |= CCR_TRIGGER_SRC;
>>
>> d->cicr |= CICR_MISALIGNED_ERR_IE | CICR_TRANS_ERR_IE;
>> +
>> + if (port_window)
>> + d->csdp |= CSDP_WRITE_LAST_NON_POSTED;
>> }
>> if (od->plat->errata & DMA_ERRATA_PARALLEL_CHANNELS)
>> d->clnk_ctrl = c->dma_ch;
>> @@ -970,6 +1007,10 @@ static struct dma_async_tx_descriptor
*omap_dma_prep_slave_sg(
>> osg->addr = sg_dma_address(sgent);
>> osg->en = en;
>> osg->fn = sg_dma_len(sgent) / frame_bytes;
>> + if (port_window && dir == DMA_MEM_TO_DEV) {
>> + osg->ei = 1;
>> + osg->fi = (-1) * (port_window - 1);
>
> Same as above.
>
--
Péter
prev parent reply other threads:[~2016-11-14 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 10:50 [PATCH 0/2] dmaengine: core/omap-dma: Support for port window Peter Ujfalusi
2016-10-25 10:50 ` [PATCH 1/2] dmaengine: dma_slave_config: add support for slave " Peter Ujfalusi
2016-10-25 10:50 ` [PATCH 2/2] dmaengine: omap-dma: Support for slave devices with data " Peter Ujfalusi
2016-11-14 4:35 ` Vinod Koul
2016-11-14 9:44 ` Peter Ujfalusi
2016-11-14 10:55 ` Vinod Koul
2016-11-14 11:49 ` Peter Ujfalusi
2016-11-14 10:53 ` Russell King - ARM Linux
2016-11-14 11:56 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=091f6dce-b1d7-6527-b8c6-147becfd8856@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).