From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE551C4338F for ; Thu, 29 Jul 2021 09:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A700E6103B for ; Thu, 29 Jul 2021 09:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235428AbhG2JSi (ORCPT ); Thu, 29 Jul 2021 05:18:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235396AbhG2JSf (ORCPT ); Thu, 29 Jul 2021 05:18:35 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D20B4C0613CF for ; Thu, 29 Jul 2021 02:18:31 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id l18so6033463wrv.5 for ; Thu, 29 Jul 2021 02:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l+nZIaXTzSWTbnhdYn/fQ9vw1KtraaQBcGvKxiJnOVw=; b=pgNV599SAM1Wu4Z7W8wsHZQ9LL9gipMaS3MRne6sF27+vnoGq0peDXC87s6c+LvmGJ viSc63sQ1dvtrJU5VSDchu9C/V6kxepVWxb5y8EGL6N+NW7+G5XZd3KbYYnINiFbgRUI 93uRowNHnRysb1ZxP9YIHHrx7E2/fnq1/Ti1P/X+iGbwocR2dyvxkfpEvshholb2rLWJ zmSo3aLoMIfkFTctYIyUl3RtJbDeCzi67pYa3G8kYHBNu5wnl1IMAAdohfSFKOHpE78J bWI1iztAGgNT0s6piNUm2/0XaSzpwl6rs/GjvjmuXtDCwCOls5sSfaVis0RuBvAUQdeP 4mVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l+nZIaXTzSWTbnhdYn/fQ9vw1KtraaQBcGvKxiJnOVw=; b=UHzApqRsIszoxO/RJFXAreRewXx/2AaXjiNkeqkzf91xsD8BkFsjVTjib9cls20Qiu S5ssiKZ6r5zyPn63duXxg49k76KLG2vYe7AmLG9LQgQtstdLZQqeaMS1obzRl7eyr1sn Xc51GrUXbxPxW4+mCC0JzIG68qCZNU2TLUHyxAGtJJL/EEKhNkFUDHPrkuhgLinXPtnf FzkR73kVWh1bLnO3CsKQHD0XeCpGZemMyIMawfzuUAMfMFhwDYW0wRKXKpNLCwNmS0rc yiuIXgqxC5ZxmiOD/lyTakIFzb2HZNr2aOytM4DkTBmq9zy+sfb6BkDkH0FEWa8ON0Fu fwmw== X-Gm-Message-State: AOAM530smHwSHtgCwTojLjrUhCtip08Cz8xydO5kmauxO18x7pgUVkqQ EyNpor5FJwI/SRxDBYnJHPW2Vw== X-Google-Smtp-Source: ABdhPJwbtN/KMFdWqOjpEGAIAmb/E5eMPOUmcD3QrH3AYbFGdp5HdwIorhiQ1NargruMZelfvpx5ow== X-Received: by 2002:adf:eb4c:: with SMTP id u12mr3809891wrn.111.1627550310476; Thu, 29 Jul 2021 02:18:30 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id c2sm2634105wrs.60.2021.07.29.02.18.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:18:29 -0700 (PDT) Subject: Re: [PATCH v2 04/16] ASoC: qcom: dt-bindings: add bindings Audio Processing manager To: Rob Herring Cc: bjorn.andersson@linaro.org, broonie@kernel.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-5-srinivas.kandagatla@linaro.org> <20210728173649.GA1290628@robh.at.kernel.org> From: Srinivas Kandagatla Message-ID: <092018be-50ae-6dda-73cd-6c7eb002dc19@linaro.org> Date: Thu, 29 Jul 2021 10:18:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210728173649.GA1290628@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Rob for the review, On 28/07/2021 18:36, Rob Herring wrote: > On Wed, Jul 14, 2021 at 04:30:27PM +0100, Srinivas Kandagatla wrote: >> This patch adds bindings support for Qualcomm Audio Processing Manager >> service in Audio DSP. >> >> Audio Process Manager is one of the static service in DSP which is >> responsible for Command/response handling, graph Management >> and Control/Event management between modules. > > This all looks fairly similar to the prior Qcom audio binding(s). It > would be nice to not see this all re-invented. > AudioReach is a new DSP signal processing framework Which is different to its previous DSP firmware(aka Elite). It makes use of ASoC Topology to load audio graphs on to the DSP which is then managed by APM (Audio Processing Manager) service. So internals are not exactly same. From device tree side we might end up with similar layout, but there are some subtle differences like clocks are managed by q6prm service instead of q6afe service in old firmware, front-end pcm dais definitions come from ASoC topology. Are you suggesting that we should reuse the old bindings (q6afe, q6asm) by add new compatible strings along with differences ? >> >> Signed-off-by: Srinivas Kandagatla >> --- >> .../devicetree/bindings/sound/qcom,q6apm.yaml | 87 +++++++++++++++++++ >> include/dt-bindings/sound/qcom,q6apm.h | 8 ++ >> 2 files changed, 95 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> create mode 100644 include/dt-bindings/sound/qcom,q6apm.h >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> new file mode 100644 >> index 000000000000..6f27567523a9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> @@ -0,0 +1,87 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/sound/qcom,q6apm.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Qualcomm Audio Process Manager binding >> + >> +maintainers: >> + - Srinivas Kandagatla >> + >> +description: | >> + This binding describes the Qualcomm Audio Process Manager service in DSP >> + >> +properties: >> + compatible: >> + const: qcom,q6apm >> + >> + reg: >> + maxItems: 1 >> + >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> +#APM Services >> +patternProperties: >> + 'apm@[0-9]+$': > > This means '.*apm' for the node name. Did you need a '^'? > yes we need begins with '^' , will add that in next version. >> + type: object >> + description: >> + APM devices use subnodes for services. >> + >> + properties: >> + compatible: >> + enum: >> + - qcom,q6apm-dais >> + - qcom,q6apm-bedais >> + >> + iommus: >> + maxItems: 1 >> + >> + "#sound-dai-cells": >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> + required: >> + - compatible >> + - reg >> + - '#sound-dai-cells' >> + >> + additionalProperties: false >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + gpr { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + gprservice@1 { >> + compatible = "qcom,q6apm"; >> + reg = <1>; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + apm@1 { >> + compatible = "qcom,q6apm-dais"; >> + #sound-dai-cells = <1>; >> + reg = <1>; >> + }; >> + >> + apm@2 { >> + compatible = "qcom,q6apm-bedais"; >> + #sound-dai-cells = <1>; >> + reg = <2>; >> + }; >> + }; >> + }; >> diff --git a/include/dt-bindings/sound/qcom,q6apm.h b/include/dt-bindings/sound/qcom,q6apm.h >> new file mode 100644 >> index 000000000000..3c3987eb6e95 >> --- /dev/null >> +++ b/include/dt-bindings/sound/qcom,q6apm.h >> @@ -0,0 +1,8 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef __DT_BINDINGS_Q6_APM_H__ >> +#define __DT_BINDINGS_Q6_APM_H__ >> + >> +/* Audio Process Manager (APM) virtual ports IDs */ >> +#include > > Why add this indirection? Rename the file if you need something to cover > both. Thats a good idea, These are basically audio endpoint device ids which should be same across different audio firmwares. I can rename this to dt-bindings/sound/qcom,adsp-audio-ports.h or something more generic to be able to reuse. --srini > >> + >> +#endif /* __DT_BINDINGS_Q6_APM_H__ */ >> -- >> 2.21.0 >> >>