From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: minyard@acm.org, Tomer Maimon <tmaimon77@gmail.com>
Cc: avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
jic23@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible
Date: Mon, 8 Aug 2022 09:20:47 +0300 [thread overview]
Message-ID: <09264520-15fc-fd35-c1d6-9e9d0230ea4a@linaro.org> (raw)
In-Reply-To: <20220805115827.GG3834@minyard.net>
On 05/08/2022 13:58, Corey Minyard wrote:
> On Thu, Aug 04, 2022 at 09:18:00PM +0300, Tomer Maimon wrote:
>> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
>> string becuase NPCM845 and NPCM750 BMCs are using identical KCS modules.
>>
>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
>> ---
>> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
>> index cbc10a68ddef..4fda76e63396 100644
>> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
>> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
>> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
>> Required properties:
>> - compatible : should be one of
>> "nuvoton,npcm750-kcs-bmc"
>> - "nuvoton,npcm845-kcs-bmc"
>> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
>
> This is just wrong. The compatible is supposed to identify the device,
> not the board the device is on. I think compatible here should be
> "npcm7xx-kcs-bmc", and just use that everywhere. It's fine if that is
No, because you propose to use wildcards as compatible which is not
correct. Compatibles must be specific.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-08-08 6:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:18 [PATCH v2] dt-binding: ipmi: add fallback to npcm845 compatible Tomer Maimon
2022-08-05 6:36 ` Krzysztof Kozlowski
2022-08-07 7:51 ` Tomer Maimon
2022-08-08 6:26 ` Krzysztof Kozlowski
2022-08-08 7:40 ` Tomer Maimon
2022-08-05 11:58 ` Corey Minyard
2022-08-07 8:03 ` Tomer Maimon
2022-08-07 12:11 ` Corey Minyard
2022-08-07 14:54 ` Tomer Maimon
2022-08-07 16:05 ` Corey Minyard
2022-08-08 6:25 ` Krzysztof Kozlowski
2022-08-08 6:24 ` Krzysztof Kozlowski
2022-08-08 6:23 ` Krzysztof Kozlowski
2022-08-08 6:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09264520-15fc-fd35-c1d6-9e9d0230ea4a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).