From: Jens Axboe <axboe@kernel.dk>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org, bfq-iosched@googlegroups.com,
oleksandr@natalenko.name, federico@willer.it
Subject: Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput
Date: Thu, 6 Dec 2018 19:23:24 -0700 [thread overview]
Message-ID: <09393ef1-9559-2042-6c83-75ed3fd529d3@kernel.dk> (raw)
In-Reply-To: <20181206181819.11148-1-paolo.valente@linaro.org>
On 12/6/18 11:18 AM, Paolo Valente wrote:
> Hi Jens,
> the first patch in this series fixes an error in the decrementing of
> the counter of the number of groups with pending I/O. This wrong
> decrement caused loss of throughput or, less likely, of control on
> I/O. The second patch is a fix of some wrong comments, which somehow
> contributed to making the above bug more difficult to find.
Are you fine with this going into 4.21? I can't quite tell what your
intent is. The first patch has a Fixes for something that went into
this series, but then patch 2 is a comment update that would not
normally be something to be applied at this stage.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-07 2:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 18:18 [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput Paolo Valente
2018-12-06 18:18 ` [PATCH BUGFIX 1/2] block, bfq: fix decrement of num_active_groups Paolo Valente
2018-12-06 18:18 ` [PATCH BUGFIX 2/2] block, bfq: fix comments on __bfq_deactivate_entity Paolo Valente
2018-12-07 2:23 ` Jens Axboe [this message]
2018-12-07 10:01 ` [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput Paolo Valente
2018-12-07 14:40 ` Jens Axboe
2019-01-14 9:09 ` Paolo Valente
2019-01-14 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09393ef1-9559-2042-6c83-75ed3fd529d3@kernel.dk \
--to=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=broonie@kernel.org \
--cc=federico@willer.it \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).