From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10ABFC43334 for ; Wed, 29 Jun 2022 15:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233239AbiF2PRM convert rfc822-to-8bit (ORCPT ); Wed, 29 Jun 2022 11:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233315AbiF2PRI (ORCPT ); Wed, 29 Jun 2022 11:17:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C6CD1012 for ; Wed, 29 Jun 2022 08:17:07 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6ZR4-0004v3-TM; Wed, 29 Jun 2022 17:16:58 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o6ZR0-003QJs-IC; Wed, 29 Jun 2022 17:16:58 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1o6ZR3-000BbH-01; Wed, 29 Jun 2022 17:16:57 +0200 Message-ID: <094a0d4e1c1b40f51ce7bec42e410500265d7a6d.camel@pengutronix.de> Subject: Re: [PATCH RESEND v5 7/8] clk: baikal-t1: Add DDR/PCIe directly controlled resets support From: Philipp Zabel To: Serge Semin , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , Thomas Bogendoerfer , linux-clk@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Wed, 29 Jun 2022 17:16:56 +0200 In-Reply-To: <20220624141853.7417-8-Sergey.Semin@baikalelectronics.ru> References: <20220624141853.7417-1-Sergey.Semin@baikalelectronics.ru> <20220624141853.7417-8-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Serge, On Fr, 2022-06-24 at 17:18 +0300, Serge Semin wrote: > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two > additional blocks with directly controlled reset signals. In particular it > concerns DDR full and initial resets and various PCIe sub-domains resets. > Let's add the direct reset assertion/de-assertion of the corresponding > flags support into the Baikal-T1 CCU driver then. It will be required at > least for the PCIe platform driver. Obviously the DDR controller isn't > supposed to be fully reset in the kernel, so the corresponding controls > are added just for the sake of the interface implementation completeness. > > Signed-off-by: Serge Semin This looks good to me, the issues with the previous patch still apply. [...] > +static int ccu_rst_set(struct reset_controller_dev *rcdev, > + unsigned long idx, bool high) > +{ > + struct ccu_rst *rst; > + > + rst = ccu_rst_get_desc(rcdev, idx); > + if (IS_ERR(rst)) { > + pr_err("Invalid reset index %lu specified\n", idx); > + return PTR_ERR(rst); > + } e.g. this should not be necessary. regards Philipp