From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbcKTDhf (ORCPT ); Sat, 19 Nov 2016 22:37:35 -0500 Received: from vern.gendns.com ([206.190.152.46]:54769 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbcKTDhd (ORCPT ); Sat, 19 Nov 2016 22:37:33 -0500 Subject: Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, khilman@kernel.org, kishon@ti.com References: <20161114144103.12120-4-ahaslam@baylibre.com> <26d7b4c1-a7ef-7250-eb6a-270182d279ea@lechnology.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <094fef2f-5901-5bc4-0574-269364aa8630@lechnology.com> Date: Sat, 19 Nov 2016 21:37:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <26d7b4c1-a7ef-7250-eb6a-270182d279ea@lechnology.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2016 09:31 PM, David Lechner wrote: > On 11/14/2016 08:41 AM, ahaslam@baylibre.com wrote: >> + ocic_mask |= 1; > > I thought that a previous patch got rid of all globals. Why is ocic_mask > still a global variable? I suppose if I read the commit message, I will know the answer ;-)