From: Hans de Goede <hdegoede@redhat.com>
To: Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
linux-serial@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
nobuhiro1.iwamatsu@toshiba.co.jp, shrirang.bagul@canonical.com,
stable@vger.kernel.org, Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] serdev: Don't claim unsupported serial devices
Date: Wed, 18 Dec 2019 11:05:40 +0100 [thread overview]
Message-ID: <096046b6-324a-8496-8599-ed7e5ffc6e3c@redhat.com> (raw)
In-Reply-To: <20191218065646.817493-1-punit1.agrawal@toshiba.co.jp>
Hi,
On 18-12-2019 07:56, Punit Agrawal wrote:
> Serdev sub-system claims all serial devices that are not already
> enumerated. As a result, no device node is created for serial port on
> certain boards such as the Apollo Lake based UP2. This has the
> unintended consequence of not being able to raise the login prompt via
> serial connection.
>
> Introduce a blacklist to reject devices that should not be treated as
> a serdev device. Add the Intel HS UART peripheral ids to the blacklist
> to bring back serial port on SoCs carrying them.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
Thank you for addressing this long standing issue.
The basic approach here looks good to me, once the minor
comments from other reviewers are addressed you can add my:
Acked-by: Hans de Goede <hdegoede@redhat.com>
to the next version.
Regards,
Hans
> ---
>
> Hi,
>
> The patch has been updated based on feedback recieved on the RFC[0].
>
> Please consider merging if there are no objections.
>
> Thanks,
> Punit
>
> [0] https://www.spinics.net/lists/linux-serial/msg36646.html
>
> drivers/tty/serdev/core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index 226adeec2aed..0d64fb7d4f36 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -663,6 +663,12 @@ static acpi_status acpi_serdev_register_device(struct serdev_controller *ctrl,
> return AE_OK;
> }
>
> +static const struct acpi_device_id serdev_blacklist_devices[] = {
> + {"INT3511", 0},
> + {"INT3512", 0},
> + { },
> +};
> +
> static acpi_status acpi_serdev_add_device(acpi_handle handle, u32 level,
> void *data, void **return_value)
> {
> @@ -675,6 +681,10 @@ static acpi_status acpi_serdev_add_device(acpi_handle handle, u32 level,
> if (acpi_device_enumerated(adev))
> return AE_OK;
>
> + /* Skip if black listed */
> + if (!acpi_match_device_ids(adev, serdev_blacklist_devices))
> + return AE_OK;
> +
> if (acpi_serdev_check_resources(ctrl, adev))
> return AE_OK;
>
>
next prev parent reply other threads:[~2019-12-18 10:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 6:56 [PATCH] serdev: Don't claim unsupported serial devices Punit Agrawal
2019-12-18 8:10 ` Greg Kroah-Hartman
2019-12-18 8:22 ` Punit Agrawal
2019-12-18 8:56 ` Johan Hovold
2019-12-18 9:09 ` Punit Agrawal
2019-12-19 8:39 ` Rafael J. Wysocki
2019-12-19 8:51 ` Johan Hovold
2019-12-19 8:58 ` Punit Agrawal
2019-12-18 10:05 ` Hans de Goede [this message]
2019-12-19 0:37 ` Punit Agrawal
2019-12-19 8:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096046b6-324a-8496-8599-ed7e5ffc6e3c@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh@kernel.org \
--cc=shrirang.bagul@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).