From: David Lechner <david@lechnology.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v4 1/3] leds: Introduce userspace leds driver
Date: Tue, 8 Nov 2016 13:08:24 -0600 [thread overview]
Message-ID: <0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com> (raw)
In-Reply-To: <0bfdfd46-35e5-321c-5759-0cc96be862fd@samsung.com>
On 11/8/16 5:26 AM, Jacek Anaszewski wrote:
> Hi David,
>
>> +struct uleds_device {
>> + struct uleds_user_dev user_dev;
>> + struct led_classdev led_cdev;
>> + struct mutex mutex;
>> + enum uleds_state state;
>> + wait_queue_head_t waitq;
>> + unsigned char brightness;
>
> I've just noticed that this is wrong, since LED subsystem
> brightness type is enum led_brightness, i.e. int.
> LED_FULL (255) value is a legacy enum value that can be overridden
> by max_brightness property.
>
> Please submit a fix so that I could merge it with the original
> patch before sending it upstream.
>
> Thanks,
> Jacek Anaszewski
>
The brightness should be a 32-bit integer then?
next prev parent reply other threads:[~2016-11-08 19:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160916191750eucas1p2437e0fa04cc99964b79cb774ef482e5a@eucas1p2.samsung.com>
2016-09-16 19:16 ` [PATCH v4 0/3] leds: Introduce userspace leds driver David Lechner
2016-09-16 19:16 ` [PATCH v4 1/3] " David Lechner
2016-09-22 13:43 ` Linus Walleij
2016-09-22 13:44 ` Linus Walleij
2016-09-22 16:45 ` David Lechner
2016-09-24 12:06 ` Pavel Machek
2016-11-08 11:26 ` Jacek Anaszewski
2016-11-08 19:08 ` David Lechner [this message]
2016-11-08 20:29 ` Jacek Anaszewski
2016-11-09 7:05 ` Pavel Machek
2016-11-09 8:44 ` Jacek Anaszewski
2016-09-16 19:16 ` [PATCH v4 2/3] leds: Use macro for max device node name size David Lechner
2016-09-16 19:16 ` [PATCH v4 3/3] tools/leds: Add uledmon program for monitoring userspace LEDs David Lechner
2016-09-20 8:56 ` [PATCH v4 0/3] leds: Introduce userspace leds driver Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0970c634-61ac-8ad7-088a-e47419c23455@lechnology.com \
--to=david@lechnology.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).