From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
osandov@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] sbitmap: Replace cmpxchg with xchg
Date: Sat, 29 Jun 2019 08:42:23 -0700 [thread overview]
Message-ID: <0979d23f-bc31-b653-51d0-867dd52bf7ee@gmail.com> (raw)
In-Reply-To: <722e1d561f0a49dc464d3a2b1be4c077f7502726.1558625912.git.asml.silence@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1764 bytes --]
Ping?
On 23/05/2019 08:39, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
>
> cmpxchg() with an immediate value could be replaced with less expensive
> xchg(). The same true if new value don't _depend_ on the old one.
>
> In the second block, atomic_cmpxchg() return value isn't checked, so
> after atomic_cmpxchg() -> atomic_xchg() conversion it could be replaced
> with atomic_set(). Comparison with atomic_read() in the second chunk was
> left as an optimisation (if that was the initial intention).
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> lib/sbitmap.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/lib/sbitmap.c b/lib/sbitmap.c
> index 155fe38756ec..7d7e0e278523 100644
> --- a/lib/sbitmap.c
> +++ b/lib/sbitmap.c
> @@ -37,9 +37,7 @@ static inline bool sbitmap_deferred_clear(struct sbitmap *sb, int index)
> /*
> * First get a stable cleared mask, setting the old mask to 0.
> */
> - do {
> - mask = sb->map[index].cleared;
> - } while (cmpxchg(&sb->map[index].cleared, mask, 0) != mask);
> + mask = xchg(&sb->map[index].cleared, 0);
>
> /*
> * Now clear the masked bits in our free word
> @@ -527,10 +525,8 @@ static struct sbq_wait_state *sbq_wake_ptr(struct sbitmap_queue *sbq)
> struct sbq_wait_state *ws = &sbq->ws[wake_index];
>
> if (waitqueue_active(&ws->wait)) {
> - int o = atomic_read(&sbq->wake_index);
> -
> - if (wake_index != o)
> - atomic_cmpxchg(&sbq->wake_index, o, wake_index);
> + if (wake_index != atomic_read(&sbq->wake_index))
> + atomic_set(&sbq->wake_index, wake_index);
> return ws;
> }
>
>
--
Yours sincerely,
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-29 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:39 [PATCH 1/1] sbitmap: Replace cmpxchg with xchg Pavel Begunkov (Silence)
2019-06-29 15:42 ` Pavel Begunkov [this message]
2019-06-29 15:51 ` Jens Axboe
2019-07-01 17:35 ` Omar Sandoval
2019-07-01 19:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0979d23f-bc31-b653-51d0-867dd52bf7ee@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).