From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D18CC433E1 for ; Sun, 19 Jul 2020 22:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5258121744 for ; Sun, 19 Jul 2020 22:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="L8a9kMdj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbgGSW0B (ORCPT ); Sun, 19 Jul 2020 18:26:01 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:40581 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgGSW0A (ORCPT ); Sun, 19 Jul 2020 18:26:00 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id D498B22FEC; Mon, 20 Jul 2020 00:25:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1595197556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P1EARcVS+vt3gGzV2O04vTL98QliSbGs8ZYhiqN1cK8=; b=L8a9kMdjygjsyDp8WZPCdrn8cqiEuXSYyDStMPiQK9XjxDkcyI5zkGtjQl5bgmqUckT/4H n8CH8YTFb3jsa8lY3vAgQzc2SQdaURhejaltLX/vnwCW5HnOn9fLrg6TZ4cGDaOi55qtwT uK3rdim4Gt1gtfOPtV/Qfj2QSw+wTKY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Jul 2020 00:25:52 +0200 From: Michael Walle To: Lee Jones Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko Subject: Re: [PATCH v5 02/13] mfd: add simple regmap based I2C driver In-Reply-To: <20200717090444.GE3165313@dell> References: <20200706175353.16404-1-michael@walle.cc> <20200706175353.16404-3-michael@walle.cc> <20200717090444.GE3165313@dell> User-Agent: Roundcube Webmail/1.4.7 Message-ID: <09810b67fb0259a57086f938cd8382c5@walle.cc> X-Sender: michael@walle.cc Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-07-17 11:04, schrieb Lee Jones: > On Mon, 06 Jul 2020, Michael Walle wrote: > >> There are I2C devices which contain several different functions but >> doesn't require any special access functions. For these kind of >> drivers >> an I2C regmap should be enough. >> >> Create an I2C driver which creates an I2C regmap and enumerates its >> children. If a device wants to use this as its MFD core driver, it has >> to add an individual compatible string. It may provide its own regmap >> configuration. >> >> Subdevices can use dev_get_regmap() on the parent to get their regmap >> instance. >> >> Signed-off-by: Michael Walle >> --- >> Changes since v4: >> - new patch. Lee, please bear with me. I didn't want to delay the >> new version (where a lot of remarks on the other patches were >> addressed) even more, just because we haven't figured out how >> to deal with the MFD part. So for now, I've included this one. >> >> drivers/mfd/Kconfig | 9 +++++++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/simple-mfd-i2c.c | 50 >> ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 60 insertions(+) >> create mode 100644 drivers/mfd/simple-mfd-i2c.c >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 33df0837ab41..f1536a710aca 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -1162,6 +1162,15 @@ config MFD_SI476X_CORE >> To compile this driver as a module, choose M here: the >> module will be called si476x-core. >> >> +config MFD_SIMPLE_MFD_I2C >> + tristate "Simple regmap based I2C devices" >> + depends on I2C >> + select MFD_CORE >> + select REGMAP_I2C >> + help >> + This is a consolidated driver for all MFD devices which are >> + basically just a regmap bus driver. >> + >> config MFD_SM501 >> tristate "Silicon Motion SM501" >> depends on HAS_DMA >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> index a60e5f835283..78d24a3e7c9e 100644 >> --- a/drivers/mfd/Makefile >> +++ b/drivers/mfd/Makefile >> @@ -264,3 +264,4 @@ obj-$(CONFIG_MFD_STMFX) += stmfx.o >> obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o >> >> obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o >> +obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o >> diff --git a/drivers/mfd/simple-mfd-i2c.c >> b/drivers/mfd/simple-mfd-i2c.c >> new file mode 100644 >> index 000000000000..1fdca89964b1 >> --- /dev/null >> +++ b/drivers/mfd/simple-mfd-i2c.c >> @@ -0,0 +1,49 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > I'm pretty sure you do not require all of these headers. Shot, I'll clean that up. >> +struct simple_mfd_i2c_config { >> + const struct regmap_config *regmap_config; >> +}; > > No need for this yet I feel. > > Let's keep it as simple as possible. ok >> +static const struct regmap_config simple_regmap_config = { >> + .reg_bits = 8, >> + .val_bits = 8, >> +}; >> + >> +static int simple_mfd_i2c_probe(struct i2c_client *i2c) >> +{ >> + const struct regmap_config *regmap_config = &simple_regmap_config; >> + const struct simple_mfd_i2c_config *config; >> + struct regmap *regmap; >> + >> + config = device_get_match_data(&i2c->dev); > > Have this return regmap_config. ok >> + if (config && config->regmap_config) >> + regmap_config = config->regmap_config; >> + >> + regmap = devm_regmap_init_i2c(i2c, regmap_config); >> + if (IS_ERR(regmap)) >> + return PTR_ERR(regmap); >> + >> + return devm_of_platform_populate(&i2c->dev); >> +} >> + >> +static const struct of_device_id simple_mfd_i2c_of_match[] = { >> + {} >> +}; >> + >> +static struct i2c_driver simple_mfd_i2c_driver = { >> + .probe_new = simple_mfd_i2c_probe, >> + .driver = { >> + .name = "simple-mfd-i2c", >> + .of_match_table = simple_mfd_i2c_of_match, >> + }, >> +}; >> +builtin_i2c_driver(simple_mfd_i2c_driver); -- -michael