archive mirror
 help / color / mirror / Atom feed
From: "Sean Estabrooks" <>
To: <>, "Andrew Morton" <>,
	"Jens Axboe" <>
Subject: [PATCH]  Block layer bug handling partial bvec
Date: Sun, 27 Jul 2003 07:48:19 -0400	[thread overview]
Message-ID: <099001c35434$f9ac3130$7f0a0a0a@lappy7> (raw)

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Previously I submitted a patch for "blk: request botched" on floppy
write.  While the patch did make the floppy work, Jens mentioned 
that an underlying error still existed.   This spurred me on to look a 
little deeper and finally i found the root cause.   

There is a bug in "ll_rw_blk.c" handling partial bvec submissions.
For whatever reason the floppy driver was triggering it more than
other users.  Note that with the attached patch, my previous 
floppy_ patch is no longer needed.


[-- Attachment #2: blk_partial_bvec.patch --]
[-- Type: application/octet-stream, Size: 503 bytes --]

--- 26test1bk/drivers/block/ll_rw_blk.c	Sun Jul 27 07:03:29 2003
+++ 26test1bk/drivers/block/ll_rw_blk.c	Sun Jul 27 07:03:59 2003
@@ -2307,8 +2307,8 @@
 			 * not a complete bvec done
 			if (unlikely(nbytes > nr_bytes)) {
-				bio_iovec(bio)->bv_offset += nr_bytes;
-				bio_iovec(bio)->bv_len -= nr_bytes;
+				bio_iovec_idx(bio, idx)->bv_offset += nr_bytes;
+				bio_iovec_idx(bio, idx)->bv_len -= nr_bytes;
 				bio_nbytes += nr_bytes;
 				total_bytes += nr_bytes;

             reply	other threads:[~2003-07-27 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-27 11:48 Sean Estabrooks [this message]
2003-07-27 12:47 ` [PATCH] Block layer bug handling partial bvec Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='099001c35434$f9ac3130$7f0a0a0a@lappy7' \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).