From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CD7C433E7 for ; Mon, 19 Oct 2020 17:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDD0A2225F for ; Mon, 19 Oct 2020 17:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gSenhv9d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbgJSRmj (ORCPT ); Mon, 19 Oct 2020 13:42:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50210 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbgJSRmj (ORCPT ); Mon, 19 Oct 2020 13:42:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603129357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mReA3kFCX+myyiXgiYscelnLZR7Th5JMT/d6TpCbjKM=; b=gSenhv9dTBKbpZpEbzYDgwZR8CYhSbFcc9jm2sR/s4S+ieRDw5UEW1aPirSsUsIGLtZpz1 TI+sQt/3PvfE2Oojxq4Ehk7fxO+f0cz65jqqfia+C1tZ+5FDMfbIhUh6xZnmJCcHgj7Ig8 MCUmIlrHHmtVGRwPvN4B2IDb8AZeYD0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-pUlWtUP8MpKMxkPVLCgPRg-1; Mon, 19 Oct 2020 13:42:36 -0400 X-MC-Unique: pUlWtUP8MpKMxkPVLCgPRg-1 Received: by mail-wr1-f69.google.com with SMTP id p6so143803wrm.23 for ; Mon, 19 Oct 2020 10:42:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mReA3kFCX+myyiXgiYscelnLZR7Th5JMT/d6TpCbjKM=; b=C1sDxPRFYZ8S57zlMAcqj5QCFPq/M3kTgwCd/EHK+jk5PU/WcrZ+zafiE7m3qjfD7/ etTIoQZOtDGQVSHSSlBZ3Pr9K9p9ub0TzT+NIXJH/JVdU5bV7y4N3Y4ie73w+xrIH6np KhPuMSDDAAgKlR9rrX2l8VzAo0Hykf1Yt/onNguc8PA1wxb586AxKEGLxWEXSA6aGpna 45ahi8r4lPIZo+VyRrYucJNEw6RT6FJfwWWuTgmZqfEXKn2fH4/B+hDGymjE4hPwSeMZ BO7JmHii0BEKSxCy/JUYpbhX5s9CSFSJnd2l2IZLpslNjPxgmOe/lua5huVLN2ddRUvv PFmQ== X-Gm-Message-State: AOAM531mDSSoXcKAD1hMRG04sC5fU0qb2QJ1936xVyJzGh7FE4k5WFmA itRvU0ULljF67cNVFBtVfHX39ld7yxSUm8zQvIZobm+3/uTm6Dna/Yzn1WLWNzW+hHoF+DkwtXe P7girMuks8oIs7bwlM1Ytmkcf X-Received: by 2002:a1c:dd85:: with SMTP id u127mr359489wmg.33.1603129355126; Mon, 19 Oct 2020 10:42:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxazz8vOXvEcDHpQHW1+LpvFk1J3aJizL23Ex5gCpbmbM8wq6DtaFvuDnkLDGC1NY8eSb4o7A== X-Received: by 2002:a1c:dd85:: with SMTP id u127mr359472wmg.33.1603129354885; Mon, 19 Oct 2020 10:42:34 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id b25sm333844wmj.21.2020.10.19.10.42.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 10:42:34 -0700 (PDT) Subject: Re: [PATCH v2 15/20] kvm: x86/mmu: Support dirty logging for the TDP MMU To: Ben Gardon Cc: LKML , kvm , Cannon Matthews , Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20201014182700.2888246-1-bgardon@google.com> <20201014182700.2888246-16-bgardon@google.com> From: Paolo Bonzini Message-ID: <099dd316-4409-7430-d543-3a33a0ad2df1@redhat.com> Date: Mon, 19 Oct 2020 19:42:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/20 19:07, Ben Gardon wrote: > On Fri, Oct 16, 2020 at 9:18 AM Paolo Bonzini wrote: >> >> On 14/10/20 20:26, Ben Gardon wrote: >>> >>> + if (kvm->arch.tdp_mmu_enabled) >>> + kvm_tdp_mmu_clear_dirty_pt_masked(kvm, slot, >>> + slot->base_gfn + gfn_offset, mask, true); >> >> This was "false" in v1, I need --verbose for this change. :) > > I don't think this changed from v1. Note that there are two callers in > mmu.c - kvm_mmu_write_protect_pt_masked and > kvm_mmu_clear_dirty_pt_masked. One calls with wrprot = true and the > other with wrprot = false. Ah, I messed up fixing the conflicts. Paolo