From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 1/4] mm: ioremap: Setup phys_addr of struct vm_struct
Date: Thu, 28 Apr 2022 09:40:37 +0800 [thread overview]
Message-ID: <09b7afdf-fb5c-486d-cc95-e1c9c0994cbb@huawei.com> (raw)
In-Reply-To: <20220427101040.bd4532c8ef093b47b3dd9eb5@linux-foundation.org>
On 2022/4/28 1:10, Andrew Morton wrote:
> On Wed, 27 Apr 2022 20:14:10 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>> Show physical address in /proc/vmallocinfo.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> mm/ioremap.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/mm/ioremap.c b/mm/ioremap.c
>> index 5fe598ecd9b7..522ef899c35f 100644
>> --- a/mm/ioremap.c
>> +++ b/mm/ioremap.c
>> @@ -32,6 +32,7 @@ void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot)
>> if (!area)
>> return NULL;
>> vaddr = (unsigned long)area->addr;
>> + area->phys_addr = addr;
>>
>> if (ioremap_page_range(vaddr, vaddr + size, addr, __pgprot(prot))) {
>> free_vm_area(area);
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
>
> I checked a bunch of arch-specific implementations of ioremap_prot()
> and they're already doing this. As far as I can tell, only csky and
> riscv actually use this file (CONFIG_GENERIC_IOREMAP=y). But you're
> ARM(?) so I'm wondering how come you're patching it?
Hi Andrew,
I found this via reading code when debug some other issue, meanwhile, there
are some code duplication of ioremap between arm64 and generic ioremap, so
1) bugfix: fix the above issue and test on riscv
2) cleanup: convert arm64 to use GENERIC_IOREMAP,
3) feature: after that, enable HAVE_IOREMAP_PROT on arm64
>
> Someone should do s/addr/phys_addr/ in this function, like the rest of
> the world (sensibly) does.
I will make it in next version.
>
>
> .
next prev parent reply other threads:[~2022-04-28 1:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 12:14 [PATCH 0/4] arm64: Cleanup ioremap() and support ioremap_prot() Kefeng Wang
2022-04-27 12:14 ` [PATCH 1/4] mm: ioremap: Setup phys_addr of struct vm_struct Kefeng Wang
2022-04-27 17:10 ` Andrew Morton
2022-04-28 1:40 ` Kefeng Wang [this message]
2022-04-28 15:41 ` Christoph Hellwig
2022-04-27 12:14 ` [PATCH 2/4] mm: ioremap: Add arch_ioremap/iounmap_check() Kefeng Wang
2022-04-27 17:04 ` Andrew Morton
2022-04-28 6:16 ` Kefeng Wang
2022-04-28 15:46 ` Christoph Hellwig
2022-04-27 18:20 ` Arnd Bergmann
2022-04-27 18:25 ` Andrew Morton
2022-04-27 20:46 ` Arnd Bergmann
2022-04-28 6:20 ` Kefeng Wang
2022-04-28 6:47 ` Arnd Bergmann
2022-04-27 12:14 ` [PATCH 3/4] arm64: mm: Convert to GENERIC_IOREMAP Kefeng Wang
2022-04-27 17:11 ` Andrew Morton
2022-04-27 12:14 ` [PATCH 4/4] arm64: Add HAVE_IOREMAP_PROT support Kefeng Wang
2022-04-28 10:46 ` [PATCH 0/4] arm64: Cleanup ioremap() and support ioremap_prot() Will Deacon
2022-04-28 11:48 ` Kefeng Wang
2022-04-28 15:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b7afdf-fb5c-486d-cc95-e1c9c0994cbb@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).