From: Nikolay Borisov <nborisov@suse.com>
To: Schspa Shi <schspa@gmail.com>, dsterba@suse.cz
Cc: clm@fb.com, dsterba@suse.com, josef@toxicpanda.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
terrelln@fb.com
Subject: Re: [PATCH v2] btrfs: zstd: use spin_lock in timer callback
Date: Wed, 13 Apr 2022 17:58:41 +0300 [thread overview]
Message-ID: <09c2a9ce-3b04-ed94-1d62-0e5a072b9dac@suse.com> (raw)
In-Reply-To: <20220411155540.36853-1-schspa@gmail.com>
On 11.04.22 г. 18:55 ч., Schspa Shi wrote:
> This is an optimization for fix fee13fe96529 ("btrfs:
> correct zstd workspace manager lock to use spin_lock_bh()")
>
> The critical region for wsm.lock is only accessed by the process context and
> the softirq context.
>
> Because in the soft interrupt, the critical section will not be preempted by the
> soft interrupt again, there is no need to call spin_lock_bh(&wsm.lock) to turn
> off the soft interrupt, spin_lock(&wsm.lock) is enough for this situation.
>
> Changelog:
> v1 -> v2:
> - Change the commit message to make it more readable.
>
> [1] https://lore.kernel.org/all/20220408181523.92322-1-schspa@gmail.com/
>
> Signed-off-by: Schspa Shi <schspa@gmail.com>
Has there been any measurable impact by this change? While it's correct it does mean that
someone looking at the code would see that in one call site we use plain spinlock and in
another a _bh version and this is somewhat inconsistent.
What's more I believe this is a noop since when softirqs are executing preemptible() would
be false due to preempt_count() being non-0 and in the bh-disabling code
in the spinlock we have:
/* First entry of a task into a BH disabled section? */
1 if (!current->softirq_disable_cnt) {
167 if (preemptible()) {
1 local_lock(&softirq_ctrl.lock);
2 /* Required to meet the RCU bottomhalf requirements. */
3 rcu_read_lock();
4 } else {
5 DEBUG_LOCKS_WARN_ON(this_cpu_read(softirq_ctrl.cnt));
6 }
7 }
In this case we'd hit the else branch.
> ---
> fs/btrfs/zstd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/zstd.c b/fs/btrfs/zstd.c
> index fc42dd0badd7..faa74306f0b7 100644
> --- a/fs/btrfs/zstd.c
> +++ b/fs/btrfs/zstd.c
> @@ -105,10 +105,10 @@ static void zstd_reclaim_timer_fn(struct timer_list *timer)
> unsigned long reclaim_threshold = jiffies - ZSTD_BTRFS_RECLAIM_JIFFIES;
> struct list_head *pos, *next;
>
> - spin_lock_bh(&wsm.lock);
> + spin_lock(&wsm.lock);
>
> if (list_empty(&wsm.lru_list)) {
> - spin_unlock_bh(&wsm.lock);
> + spin_unlock(&wsm.lock);
> return;
> }
>
> @@ -137,7 +137,7 @@ static void zstd_reclaim_timer_fn(struct timer_list *timer)
> if (!list_empty(&wsm.lru_list))
> mod_timer(&wsm.timer, jiffies + ZSTD_BTRFS_RECLAIM_JIFFIES);
>
> - spin_unlock_bh(&wsm.lock);
> + spin_unlock(&wsm.lock);
> }
>
> /*
next prev parent reply other threads:[~2022-04-13 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:15 [PATCH] btrfs: zstd: use spin_lock in timer function Schspa Shi
2022-04-08 18:44 ` David Sterba
2022-04-09 7:36 ` Schspa Shi
2022-04-11 13:51 ` David Sterba
2022-04-11 15:55 ` [PATCH v2] btrfs: zstd: use spin_lock in timer callback Schspa Shi
2022-04-13 14:58 ` Nikolay Borisov [this message]
2022-04-13 16:00 ` David Sterba
2022-04-13 16:03 ` Schspa Shi
2022-04-13 19:08 ` Nikolay Borisov
2022-04-14 16:39 ` Schspa Shi
2022-04-14 19:26 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09c2a9ce-3b04-ed94-1d62-0e5a072b9dac@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schspa@gmail.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).