From: "lihuisong (C)" <lihuisong@huawei.com>
To: Robbie King <robbiek@xsightlabs.com>,
Sudeep Holla <sudeep.holla@arm.com>
Cc: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<rafael@kernel.org>, <rafael.j.wysocki@intel.com>,
<wanghuiqiang@huawei.com>, <huangdaode@huawei.com>,
<tanxiaofei@huawei.com>
Subject: Re: [RFC] ACPI: PCC: Support shared interrupt for multiple subspaces
Date: Mon, 7 Nov 2022 14:24:45 +0800 [thread overview]
Message-ID: <09e0a108-9f22-a9a0-2145-a81936745887@huawei.com> (raw)
In-Reply-To: <ca35058d-1f40-3f85-9e2d-bfb29c8625cb@xsightlabs.com>
在 2022/11/4 23:39, Robbie King 写道:
> On 11/4/2022 11:15 AM, Sudeep Holla wrote:
>> On Fri, Nov 04, 2022 at 11:04:22AM -0400, Robbie King wrote:
>>> Hello Huisong, your raising of the shared interrupt issue is very
>>> timely, I
>>> am working to implement "Extended PCC subspaces (types 3 and 4)"
>>> using PCC
>>> on the ARM RDN2 reference platform as a proof of concept, and
>>> encountered
>>> this issue as well. FWIW, I am currently testing using Sudeep's
>>> patch with
>>> the "chan_in_use" flag removed, and so far have not encountered any
>>> issues.
>>>
>>
>> Interesting, do you mean the patch I post in this thread but without the
>> whole chan_in_use flag ?
>
> That's right, diff I'm running with is attached to end of message.
Hello Robbie, In multiple subspaces scenario, there is a problem
that OS doesn't know which channel should respond to the interrupt
if no this chan_in_use flag. If you have not not encountered any
issues in this case, it may be related to your register settings.
@Sudeep, what shoud we do next?
>
>>
>>> I think the RDN2 may provide an example of a write only interrupt
>>> acknowledge mechanism mentioned by Sudeep.
>>>
>>
>> Yes.
>>
>>> The RDN2 reference design uses the MHUv2 IP for the doorbell
>>> mechanism. If
>>> my implementation is correct (and it quite possibly is not),
>>> acknowledging
>>> the DB interrupt from the platform is accomplished by writing a 1 to
>>> the
>>> appropriate bit in the receiver channel window CH_CLR register,
>>> which is
>>> documented as:
>>>
>>> Channel flag clear.
>>> Write 0b1 to a bit clears the corresponding bit in the CH_ST and
>>> CH_ST_MSK.
>>> Writing 0b0 has no effect.
>>> Each bit always reads as 0b0.
>>>
>>
>> Correct, on this MHUv[1-2], it is write only register and it reads zero.
>> So basically you will ignore the interrupt if we apply the logic Huisong
>> proposed initially.
>>
>>> in the "Arm Corstone SSE-700 Subsystem Technical Reference Manual".
>>>
>>> Apologies if I am off in the weeds here as I have only been working
>>> with
>>> PCC/SCMI for a very short period of time.
>>
>> Good to know info :).
>>
>
> It helps that your linux / firmware code is easy to follow! :)
>
> One other minor issue I encountered was that a NULL GAS (all zeros)
> doesn't
> seem to be supported by pcc_chan_reg_init, may be a good opportunity
> for me
> to submit my first RFC...
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ed18936b8ce6..3fa7335d15b0 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -100,6 +100,7 @@ struct pcc_chan_info {
> struct pcc_chan_reg cmd_update;
> struct pcc_chan_reg error;
> int plat_irq;
> + unsigned int plat_irq_flags;
> };
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index ed18936b8ce6..3fa7335d15b0 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -100,6 +100,7 @@ struct pcc_chan_info {
> struct pcc_chan_reg cmd_update;
> struct pcc_chan_reg error;
> int plat_irq;
> + unsigned int plat_irq_flags;
> };
>
> #define to_pcc_chan_info(c) container_of(c, struct pcc_chan_info, chan)
> @@ -221,6 +222,12 @@ static int pcc_map_interrupt(u32 interrupt, u32
> flags)
> return acpi_register_gsi(NULL, interrupt, trigger, polarity);
> }
>
> +static bool pcc_chan_plat_irq_can_be_shared(struct pcc_chan_info *pchan)
> +{
> + return (pchan->plat_irq_flags & ACPI_PCCT_INTERRUPT_MODE) ==
> + ACPI_LEVEL_SENSITIVE;
> +}
> +
> /**
> * pcc_mbox_irq - PCC mailbox interrupt handler
> * @irq: interrupt number
> @@ -310,9 +317,12 @@ pcc_mbox_request_channel(struct mbox_client *cl,
> int subspace_id)
>
> if (pchan->plat_irq > 0) {
> int rc;
> + unsigned long irqflags;
>
> - rc = devm_request_irq(dev, pchan->plat_irq,
> pcc_mbox_irq, 0,
> - MBOX_IRQ_NAME, chan);
> + irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?
> + IRQF_SHARED | IRQF_ONESHOT : 0;
> + rc = devm_request_irq(dev, pchan->plat_irq, pcc_mbox_irq,
> + irqflags, MBOX_IRQ_NAME, chan);
> if (unlikely(rc)) {
> dev_err(dev, "failed to register PCC interrupt
> %d\n",
> pchan->plat_irq);
> @@ -458,6 +468,8 @@ static int pcc_parse_subspace_irq(struct
> pcc_chan_info *pchan,
> return -EINVAL;
> }
>
> + pchan->plat_irq_flags = pcct_ss->flags;
> +
> if (pcct_ss->header.type ==
> ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
> struct acpi_pcct_hw_reduced_type2 *pcct2_ss = (void
> *)pcct_ss;
>
>
> .
next prev parent reply other threads:[~2022-11-07 6:24 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 3:40 [RFC] ACPI: PCC: Support shared interrupt for multiple subspaces Huisong Li
2022-10-26 6:10 ` lihuisong (C)
2022-10-27 11:10 ` Sudeep Holla
2022-10-27 12:48 ` lihuisong (C)
2022-10-27 15:53 ` Sudeep Holla
2022-10-28 7:55 ` lihuisong (C)
2022-10-31 10:40 ` Sudeep Holla
2022-11-01 2:49 ` lihuisong (C)
2022-11-04 15:04 ` Robbie King
2022-11-04 15:15 ` Sudeep Holla
2022-11-04 15:39 ` Robbie King
2022-11-07 6:24 ` lihuisong (C) [this message]
2022-11-17 18:09 ` Robbie King
2022-11-19 7:32 ` lihuisong (C)
2022-11-21 16:59 ` Robbie King
2022-11-22 3:42 ` lihuisong (C)
2022-11-22 3:30 ` [RFC V2] " Huisong Li
2022-11-22 13:46 ` Sudeep Holla
2022-11-23 3:36 ` lihuisong (C)
2022-12-03 9:51 ` [RFC-V3 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt Huisong Li
2022-12-03 9:51 ` [RFC-V3 1/2] mailbox: pcc: Add processing platform notification for slave subspaces Huisong Li
2023-02-06 15:39 ` Sudeep Holla
2023-02-07 2:27 ` lihuisong (C)
2023-02-13 21:18 ` Robbie King
2023-02-14 1:24 ` lihuisong (C)
2022-12-03 9:51 ` [RFC-V3 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2022-12-14 2:57 ` [RFC-V3 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt lihuisong (C)
2022-12-30 1:07 ` lihuisong (C)
2023-01-04 11:06 ` Sudeep Holla
2023-01-05 1:14 ` lihuisong (C)
2023-01-28 1:49 ` lihuisong (C)
2023-02-16 6:36 ` [PATCH " Huisong Li
2023-02-16 6:36 ` [PATCH 1/2] mailbox: pcc: Add processing platform notification for slave subspaces Huisong Li
2023-03-01 13:24 ` Sudeep Holla
2023-03-02 1:57 ` lihuisong (C)
2023-03-02 13:52 ` Sudeep Holla
2023-03-03 1:50 ` lihuisong (C)
2023-03-03 11:07 ` Sudeep Holla
2023-03-04 9:49 ` lihuisong (C)
2023-02-16 6:36 ` [PATCH 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2023-03-01 13:36 ` Sudeep Holla
2023-03-02 2:17 ` lihuisong (C)
2023-03-02 14:02 ` Sudeep Holla
[not found] ` <020cc964-9938-7ebe-7514-125cd041bfcb@huawei.com>
2023-03-03 11:14 ` Sudeep Holla
2023-03-04 9:47 ` lihuisong (C)
2023-03-10 20:14 ` Sudeep Holla
2023-03-14 1:05 ` lihuisong (C)
2023-02-27 13:09 ` [PATCH 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt lihuisong (C)
2023-03-14 11:11 ` [PATCH v2 " Huisong Li
2023-03-14 11:11 ` [PATCH v2 1/2] mailbox: pcc: Add support for platform notification handling Huisong Li
2023-03-27 11:30 ` Sudeep Holla
2023-03-27 12:25 ` lihuisong (C)
2023-03-27 13:27 ` Sudeep Holla
2023-03-14 11:11 ` [PATCH v2 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2023-03-24 2:30 ` [PATCH v2 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt lihuisong (C)
2023-03-27 11:33 ` Sudeep Holla
2023-03-27 12:31 ` lihuisong (C)
2023-04-10 1:26 ` lihuisong (C)
2023-04-11 14:47 ` Robbie King
2023-04-14 1:05 ` lihuisong (C)
2023-04-14 13:48 ` Robbie King
2023-04-18 2:21 ` lihuisong (C)
2023-04-21 10:55 ` Sudeep Holla
2023-04-23 3:58 ` lihuisong (C)
2023-04-25 13:22 ` lihuisong (C)
2023-04-23 11:03 ` [PATCH v3 " Huisong Li
2023-04-23 11:03 ` [PATCH v3 1/2] mailbox: pcc: Add support for platform notification handling Huisong Li
2023-04-23 11:03 ` [PATCH v3 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2023-04-25 14:41 ` [PATCH v3 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt Sudeep Holla
2023-05-25 12:25 ` lihuisong (C)
2023-05-04 1:30 ` lihuisong (C)
2023-05-09 9:06 ` Sudeep Holla
2023-06-13 12:57 ` [PATCH v4 " Huisong Li
2023-06-13 12:57 ` [PATCH v4 1/2] mailbox: pcc: Add support for platform notification handling Huisong Li
2023-06-13 12:57 ` [PATCH v4 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2023-06-14 15:58 ` [PATCH v4 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt Sudeep Holla
2023-07-14 6:39 ` lihuisong (C)
2023-07-21 12:31 ` lihuisong (C)
2023-06-15 1:58 ` Hanjun Guo
2023-08-01 6:38 ` [PATCH RESEND " Huisong Li
2023-08-01 6:38 ` [PATCH RESEND v4 1/2] mailbox: pcc: Add support for platform notification handling Huisong Li
2023-08-01 6:38 ` [PATCH RESEND v4 2/2] mailbox: pcc: Support shared interrupt for multiple subspaces Huisong Li
2023-08-01 9:38 ` [PATCH RESEND v4 0/2] mailbox: pcc: Support platform notification for type4 and shared interrupt Sudeep Holla
2023-08-09 11:44 ` lihuisong (C)
2023-08-17 6:50 ` lihuisong (C)
2023-08-26 2:40 ` lihuisong (C)
[not found] ` <AS8P193MB233566815E722D9B3B13B5EECAE2A@AS8P193MB2335.EURP193.PROD.OUTLOOK.COM>
2023-08-28 1:03 ` lihuisong (C)
2023-08-29 9:55 ` Sudeep Holla
2023-09-21 13:52 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e0a108-9f22-a9a0-2145-a81936745887@huawei.com \
--to=lihuisong@huawei.com \
--cc=huangdaode@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robbiek@xsightlabs.com \
--cc=sudeep.holla@arm.com \
--cc=tanxiaofei@huawei.com \
--cc=wanghuiqiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).