From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbeEPAbr (ORCPT ); Tue, 15 May 2018 20:31:47 -0400 Received: from vern.gendns.com ([206.190.152.46]:59223 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbeEPAbp (ORCPT ); Tue, 15 May 2018 20:31:45 -0400 Subject: =?UTF-8?Q?Re:_[PATCH_v10_00/27]_ARM:_davinci:_convert_to_common_clo?= =?UTF-8?B?Y2sgZnJhbWV3b3Jr4oCL?= To: Adam Ford , Bartosz Golaszewski Cc: linux-clk , devicetree , arm-soc , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , Bartosz Golaszewski , Linux Kernel Mailing List References: <20180509172606.29387-1-david@lechnology.com> From: David Lechner Message-ID: <09e0edb3-70a1-a99f-7b06-05832c9aade1@lechnology.com> Date: Tue, 15 May 2018 19:31:41 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/15/18 5:44 PM, Adam Ford wrote: > On Tue, May 15, 2018 at 4:25 AM, Bartosz Golaszewski wrote: >> 2018-05-14 2:40 GMT+02:00 Adam Ford : >>> On Wed, May 9, 2018 at 12:25 PM, David Lechner wrote: >>>> This series converts mach-davinci to use the common clock framework. >>>> >>>> The series works like this, the first 3 patches fix some issues with the clock >>>> drivers that have already been accepted into the mainline kernel. >>>> >>>> Then, starting with "ARM: davinci: pass clock as parameter to >>>> davinci_timer_init()", we get the mach code ready for the switch by adding the >>>> code needed for the new clock drivers and adding #ifndef CONFIG_COMMON_CLK >>>> around the legacy clocks so that we can switch easily between the old and the >>>> new. >>>> >>>> "ARM: davinci: switch to common clock framework" actually flips the switch >>>> to start using the new clock drivers. Then the next 8 patches remove all >>>> of the old clock code. >>>> >>>> The final four patches add device tree clock support to the one SoC that >>>> supports it. >>>> >>>> This series has been tested on TI OMAP-L138 LCDK (both device tree and legacy >>>> board file). >>>> >>> >>> I am not sure if I did something wrong, but I attempted to build and I >>> wasn't able to boot the da850-evm.dtb your repo common-clk-v11, >>> however the legacy board file boot was OK. >>> >>> make davinci_all_defconfig ARCH=arm >>> make zImage modules da850-evm.dtb ARCH=arm CROSS_COMPILE=arm-linux- -j8 >>> >>> 3140416 bytes read in 1464 ms (2 MiB/s) >>> 20353 bytes read in 15 ms (1.3 MiB/s) >>> ## Flattened Device Tree blob at c0600000 >>> Booting using the fdt blob at 0xc0600000 >>> Loading Device Tree to c7e57000, end c7e5ef80 ... OK >>> >>> Starting kernel ... >>> >>> Uncompressing Linux... done, booting the kernel. >>> >>> (and hang) >>> >>> If you have some suggestions, I am try them as I get time. >>> >>> adam >>> >> >> Runs fine on da850-lcdk and dm365-evm. I'll test the da850-evm >> tomorrow when I'll have access to it. > > I set the bootargs to: bootargs=console=ttyS2,115200n8 > clk_ignore_unused root=/dev/mmcblk0p2 rw rootfstype=ext4 rootwait It looks like you forgot earlyprintk in your bootargs. > > I enabled DEBUG_LL and EARLY_PRINTK, yet when it loads, I only get: > > ## Flattened Device Tree blob at c0600000 > Booting using the fdt blob at 0xc0600000 > Loading Device Tree to c7e57000, end c7e5ef35 ... OK > > Starting kernel ... > > Uncompressing Linux... done, booting the kernel. > > > I am doing this at my home, so I don't have a debugger for the > DA850-EVM. I am using a SOM that is an AM1808, but I vaguely remember > something about enabling a DSP clock somewhere, but I cannot seem to > find the e-mail. I know its counter intuitive that we'd need to > enable a clock that runs the DSP since it doesn't exist on the AM1808, > but I would have thought the clk_ignore_unused would have worked > around that issue. > > If someone else has a DA850-EVM or suggestions, I'm willing to try > them as I have time. > > adam >> >> Bart