From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Parth Shah <parth@linux.ibm.com>, Qais Yousef <qais.yousef@arm.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, vincent.guittot@linaro.org,
patrick.bellasi@matbug.net, valentin.schneider@arm.com,
pavel@ucw.cz, dhaval.giani@oracle.com, qperret@qperret.net,
David.Laight@ACULAB.COM, morten.rasmussen@arm.com,
pjt@google.com, tj@kernel.org, viresh.kumar@linaro.org,
rafael.j.wysocki@intel.com, daniel.lezcano@linaro.org
Subject: Re: [RFC 3/3] Allow sched_{get,set}attr to change latency_tolerance of the task
Date: Fri, 6 Dec 2019 17:04:56 +0100 [thread overview]
Message-ID: <09e9a3e1-9c43-a541-01e6-e1b429a63a6f@arm.com> (raw)
In-Reply-To: <ffe4f4de-d433-91be-00ce-20b625807f20@arm.com>
On 05.12.19 10:24, Dietmar Eggemann wrote:
> On 03/12/2019 16:51, Parth Shah wrote:
>>
>> On 12/3/19 2:09 PM, Qais Yousef wrote:
>>> On 11/25/19 15:16, Parth Shah wrote:
>
> [...]
>
>>>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>>>> index ea7abbf5c1bb..dfd36ec14404 100644
>>>> --- a/kernel/sched/core.c
>>>> +++ b/kernel/sched/core.c
>>>> @@ -4695,6 +4695,9 @@ static void __setscheduler_params(struct task_struct *p,
>>>> p->rt_priority = attr->sched_priority;
>>>> p->normal_prio = normal_prio(p);
>>>> set_load_weight(p, true);
>>>> +
>>>> + /* Change latency tolerance of the task if !SCHED_FLAG_KEEP_PARAMS */
>
> IMHO, this comment seems to be gratuitous.
>
>>>> + p->latency_tolerance = attr->sched_latency_tolerance;
>>>> }
>
> [...]
>
This also would require some changes to UAPI
(include/uapi/linux/sched.h, include/uapi/linux/sched/types.h), see
commit a509a7cd7974 ("sched/uclamp: Extend sched_setattr() to support
utilization clamping") and tools headers UAPI
(tools/include/uapi/linux/sched.h), see commit c093de6bd3c5 ("tools
headers UAPI: Sync sched.h with the kernel").
next prev parent reply other threads:[~2019-12-06 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 9:46 [RFC 0/3] Introduce per-task latency_tolerance for scheduler hints Parth Shah
2019-11-25 9:46 ` [RFC 1/3] Introduce latency-tolerance as an per-task attribute Parth Shah
2019-12-03 8:36 ` Qais Yousef
2019-12-03 15:47 ` Parth Shah
2019-12-05 9:24 ` Dietmar Eggemann
2019-12-05 11:42 ` Parth Shah
2019-11-25 9:46 ` [RFC 2/3] Propagate parent task's latency requirements to the child task Parth Shah
2019-11-25 9:46 ` [RFC 3/3] Allow sched_{get,set}attr to change latency_tolerance of the task Parth Shah
2019-12-03 8:39 ` Qais Yousef
2019-12-03 15:51 ` Parth Shah
2019-12-05 9:24 ` Dietmar Eggemann
2019-12-06 16:04 ` Dietmar Eggemann [this message]
2019-12-08 5:52 ` Parth Shah
2019-12-05 9:24 ` [RFC 0/3] Introduce per-task latency_tolerance for scheduler hints Dietmar Eggemann
2019-12-05 10:49 ` Valentin Schneider
2019-12-05 14:03 ` Dietmar Eggemann
2019-12-05 17:13 ` Parth Shah
2019-12-06 12:31 ` Dietmar Eggemann
2019-12-08 5:57 ` Parth Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e9a3e1-9c43-a541-01e6-e1b429a63a6f@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=David.Laight@ACULAB.COM \
--cc=daniel.lezcano@linaro.org \
--cc=dhaval.giani@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qais.yousef@arm.com \
--cc=qperret@qperret.net \
--cc=rafael.j.wysocki@intel.com \
--cc=tj@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).