From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "prarit@redhat.com" <prarit@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxwifi <linuxwifi@intel.com>,
"Coelho, Luciano" <luciano.coelho@intel.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Ivgi, Chaya Rachel" <chaya.rachel.ivgi@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Sharon, Sara" <sara.sharon@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded
Date: Thu, 14 Jul 2016 09:44:22 +0000 [thread overview]
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com> (raw)
In-Reply-To: <20160714092408.GA27271@redhat.com>
>
> On Mon, Jul 11, 2016 at 06:27:30PM +0000, Grumbach, Emmanuel wrote:
> > I guess that works, but it seems wrong to me. Usually, registration
> > should happen only upon INIT, and yes, at that time the firmware is
> > not ready to provide the information yet.
> <snip>
> > >
> > > As can be seen in the current code base, iwl_mvm_tzone_get_temp()
> > > will return -EIO 100% of the time when the firmware doesn't support
> > > reading the
>
> If I understad correctly this error happen 100% of the time, not only during
> init. Hence seems there is an issue here, i.e. cur_ucode is not marked
> correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the
> time (iwl_mvm_is_tt_in_fw() incorrecly return true on Prarit device ? ).
Cur_ucode will not be IWL_UCODE_REGULAR until you load the firmware which
will happen upon ifup.
>
> BTW, you implement thermal_zone device, but do you also need hwmon
> device? Perhaps using theramal_zone_params no_hwmon option would be
> proper here?
That's an interesting direction. I'd have to check, but TBH, I am not familiar with
that code. Luca was very involved during the development but he is not available
right now. I will be back more the less when the merge window will close :)
>
> Stanislaw
next prev parent reply other threads:[~2016-07-14 9:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 15:18 [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded Prarit Bhargava
2016-07-11 16:07 ` Coelho, Luciano
2016-07-11 17:00 ` Prarit Bhargava
2016-07-11 18:00 ` Emmanuel Grumbach
2016-07-11 18:19 ` Prarit Bhargava
2016-07-11 18:27 ` Grumbach, Emmanuel
2016-07-11 20:31 ` Prarit Bhargava
2016-07-13 6:50 ` Kalle Valo
2016-07-13 7:24 ` Luca Coelho
2016-07-13 10:20 ` Prarit Bhargava
2016-07-14 8:01 ` Kalle Valo
2016-07-14 9:08 ` Grumbach, Emmanuel
2016-07-13 10:01 ` Prarit Bhargava
2016-07-14 7:13 ` Kalle Valo
2016-07-14 9:24 ` Stanislaw Gruszka
2016-07-14 9:44 ` Grumbach, Emmanuel [this message]
2016-07-15 11:25 ` Stanislaw Gruszka
2016-07-15 12:14 ` Prarit Bhargava
2016-07-17 6:13 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0BA3FCBA62E2DC44AF3030971E174FB3466901DA@hasmsx107.ger.corp.intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=chaya.rachel.ivgi@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=sara.sharon@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).