From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757238AbdJQXB4 convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 19:01:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:15715 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbdJQXBz (ORCPT ); Tue, 17 Oct 2017 19:01:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="163795217" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through Thread-Topic: [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through Thread-Index: AQHTQ3WqMILpnJDs10mJObmgPTxxqKLpJkQA Date: Tue, 17 Oct 2017 23:01:52 +0000 Message-ID: <0BB0D9A1-2A0E-415F-B772-72C9C069FD18@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: <0E784B2E0AF38245B9FF2CAD2A02965D@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c > index f3bf238..6943987 100644 > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c > @@ -1175,6 +1175,7 @@ ldlm_cancel_no_wait_policy(struct ldlm_namespace *ns, struct ldlm_lock *lock, > case LDLM_IBITS: > if (ns->ns_cancel && ns->ns_cancel(lock) != 0) > break; > + /* fall through */ > default: > result = LDLM_POLICY_SKIP_LOCK; > lock_res_and_lock(lock); > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation