From: "Du, Changbin" <changbin.du@intel.com>
To: John Youn <John.Youn@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbi@ti.com" <balbi@ti.com>
Subject: RE: [PATCH 0/2] Two fix for dwc2 gadget driver
Date: Thu, 3 Dec 2015 04:23:09 +0000 [thread overview]
Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01DE83B2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2B3535C5ECE8B5419E3ECBE30077290901DC3ED679@US01WEMBX2.internal.synopsys.com>
> On 11/29/2015 9:29 PM, changbin.du@intel.com wrote:
> > From: "Du, Changbin" <changbin.du@intel.com>
> >
> > With the first patch, enable a enabled ep will return -EBUSY.
> > The second patch forbid queuing on disabled ep to avoid panic.
>
>
> The usb_ep->enabled flag was added in 4.4.
>
> It looks like these same checks are also added at the API level in the
> usb_ep_enable() and usb_ep_disable().
>
> In case this is bypassed we should probably add them in the gadget
> anyways but using the existing flag.
>
> Regards,
> John
>
Hmm, just learnt the flag on gadget API layer. And I just see usb_ep_enable return success if it is already enabled.
But I think it should return an error to inform the caller. Because the ep configuration may probably be changed.
In this case, usb_ep_enable will do different behavior.
Hmm, the usb_ep_queue doesn't check the enabled flag. Should be added. Let me have a try.
Best Regards,
Changbin
next prev parent reply other threads:[~2015-12-03 4:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 5:21 [PATCH 0/2] Two fix for dwc2 gadget driver changbin.du
2015-11-30 5:21 ` [PATCH 1/2] usb: dwc2: add ep enabled flag to avoid double enable/disable changbin.du
2015-12-10 17:26 ` Felipe Balbi
2015-12-14 3:23 ` Du, Changbin
2015-11-30 5:21 ` [PATCH 2/2] usb: dwc2: forbid queuing request to a disabled ep changbin.du
2015-12-10 17:27 ` Felipe Balbi
2015-12-03 1:20 ` [PATCH 0/2] Two fix for dwc2 gadget driver John Youn
2015-12-03 4:23 ` Du, Changbin [this message]
2015-12-04 7:21 ` [PATCH] usb: gadget: forbid queuing request to a disabled ep changbin.du
2015-12-10 17:28 ` Felipe Balbi
2015-12-14 3:48 ` [PATCH v2] " changbin.du
2015-12-14 10:20 ` Du, Changbin
2015-12-16 16:52 ` Felipe Balbi
2015-12-17 9:35 ` Du, Changbin
2015-12-17 10:00 ` [PATCH v3] " changbin.du
2015-12-17 15:26 ` Felipe Balbi
2015-12-18 7:34 ` Du, Changbin
2015-12-18 7:36 ` [PATCH v4] " changbin.du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C18FE92A7765D4EB9EE5D38D86A563A01DE83B2@SHSMSX103.ccr.corp.intel.com \
--to=changbin.du@intel.com \
--cc=John.Youn@synopsys.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).