From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932952AbbLRHek (ORCPT ); Fri, 18 Dec 2015 02:34:40 -0500 Received: from mga04.intel.com ([192.55.52.120]:5405 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbbLRHei convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2015 02:34:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,445,1444719600"; d="scan'208";a="15395860" From: "Du, Changbin" To: Felipe Balbi CC: "gregkh@linuxfoundation.org" , "John.Youn@synopsys.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lkp@01.org" , "Wu, Fengguang" Subject: RE: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep Thread-Topic: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep Thread-Index: AQHROLLqSTdJsb6ctEW+BdfVHafJC57OxxeAgAGTwpA= Date: Fri, 18 Dec 2015 07:34:32 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A01DF9007@SHSMSX103.ccr.corp.intel.com> References: <87h9jifi9x.fsf@saruman.tx.rr.com> <1450346431-8064-1-git-send-email-changbin.du@intel.com> <87bn9pdrkq.fsf@saruman.tx.rr.com> In-Reply-To: <87bn9pdrkq.fsf@saruman.tx.rr.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h > > index 3d583a1..0c5d9ea 100644 > > --- a/include/linux/usb/gadget.h > > +++ b/include/linux/usb/gadget.h > > @@ -402,6 +402,9 @@ static inline void usb_ep_free_request(struct > usb_ep *ep, > > static inline int usb_ep_queue(struct usb_ep *ep, > > struct usb_request *req, gfp_t gfp_flags) > > { > > + if (WARN_ON_ONCE(!ep->enabled && !ep->address)) > > this will only trigger for a disabled ep0. Are you testing any of your > patches at all ? > > -- > balbi Oops, I sent a wrong patch. I will send right patch again as v4, very sorry for this. The right patch has been verified on 3.14 by back-porting related 1 patch.