From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "NeilBrown" <neilb@suse.de>, <linux-kernel@vger.kernel.org>,
<linux-raid@vger.kernel.org>
Subject: RE: raid5: coding style cleanup / refactor
Date: Tue, 12 Jun 2007 14:32:42 -0700 [thread overview]
Message-ID: <0C7297FA1D2D244A9C7F6959C0BF1E5201FDE2CB@azsmsx413.amr.corp.intel.com> (raw)
In-Reply-To: <20070612142532.b45ee9bf.akpm@linux-foundation.org>
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Unfortunately these cleanups get into a huge fight with your very own
> git-md-accel.patch:
>
Yes, you missed the note that said:
Note, I have not rebased git-md-accel yet. While that is
happening I
wanted to have this patch out for review.
> I assume that you're prepared to repair all that damage to your tree,
but
> it seems a bit masochistic?
It's either this or have an inconsistent coding style throughout
raid5.c. I figure it is worth it to have reduced code duplication
between raid5 and raid6, and it makes it easier to add new cache
features going forward. I have a few more cleanups to add for a rev2 of
this patch, but I will hold that off until the rebase is done.
Dan
next prev parent reply other threads:[~2007-06-12 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 17:41 raid5: coding style cleanup / refactor Dan Williams
2007-06-12 21:25 ` Andrew Morton
2007-06-12 21:32 ` Williams, Dan J [this message]
2007-06-12 22:09 ` Dan Williams
2007-06-13 18:53 ` Dan Williams
2007-06-14 21:08 ` Bill Davidsen
2007-06-15 2:39 ` Dan Williams
2007-06-15 22:39 ` Neil Brown
2007-06-15 23:55 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C7297FA1D2D244A9C7F6959C0BF1E5201FDE2CB@azsmsx413.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).