From: Marcel Holtmann <marcel@holtmann.org>
To: Jupeng Zhong <zjp734690220@163.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Markus.Elfring@web.de, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jupeng Zhong <zhongjupeng@yulong.com>
Subject: Re: [PATCH v2] Bluetooth: btusb: Fix memory leak in btusb_mtk_wmt_recv
Date: Tue, 2 Feb 2021 17:26:55 +0100 [thread overview]
Message-ID: <0C7BC6BB-9FC7-4857-8DDF-DA1FC56E15B7@holtmann.org> (raw)
In-Reply-To: <20210202013913.15324-1-zjp734690220@163.com>
Hi Jupeng,
> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should be
> released.
>
> Omit the labels “err_out” and “err_free_skb” in this function
> implementation so that the desired exception handling code
> would be directly specified in the affected if branches.
>
> Fixes: a1c49c434e15 ("btusb: Add protocol support for MediaTek MT7668U USB devices")
> Signed-off-by: Jupeng Zhong <zhongjupeng@yulong.com>
> ---
> drivers/bluetooth/btusb.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
patch does not apply cleanly to bluetooth-next tree. Please rebase.
Regards
Marcel
parent reply other threads:[~2021-02-02 16:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210202013913.15324-1-zjp734690220@163.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C7BC6BB-9FC7-4857-8DDF-DA1FC56E15B7@holtmann.org \
--to=marcel@holtmann.org \
--cc=Markus.Elfring@web.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=zhongjupeng@yulong.com \
--cc=zjp734690220@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).