From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753112AbbEUFj4 (ORCPT ); Thu, 21 May 2015 01:39:56 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:42110 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbbEUFjy convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 01:39:54 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat9hdPszueM X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent From: "Dr. H. Nikolaus Schaller" In-Reply-To: <20150520222053.GC28218@earth> Date: Thu, 21 May 2015 07:39:52 +0200 Cc: Krzysztof Kozlowski , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <0D9D5B5F-3FAB-4AC4-89DA-1001F522BD02@goldelico.com> References: <1432019582-27612-1-git-send-email-k.kozlowski@samsung.com> <77C4D085-96E6-4874-BD7A-AC4BDFAC3A58@goldelico.com> <20150520222053.GC28218@earth> To: Sebastian Reichel X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 21.05.2015 um 00:20 schrieb Sebastian Reichel : > Hi, > > On Tue, May 19, 2015 at 10:28:39AM +0200, Dr. H. Nikolaus Schaller wrote: >> Am 19.05.2015 um 09:13 schrieb Krzysztof Kozlowski : >>> Changes since v1: >>> ================= >>> 1. Patch 2: fix invalid member used for container_of(). >>> 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register() >>> if parent is missing. >>> >>> >>> Description: >>> ============ >>> This is an idea to fix issue in bq27x00 driver (and probably in others) >>> reported by H. Nikolaus Schaller [0]. >>> >>> The fixes are marked RFC/RFT because: >>> 1. I do not have bq27x00-like device. I confirmed this and tested on >>> modified drivers (max77693, ACPI AC). These drivers are not >>> impacted by the issue but one can easily adjust them to reproduce >>> the problem. >>> 2. The first uevent coming from power_supply_register() is now >>> different because it won't contain device properties. I am >>> not sure how this impacts userspace. >>> >>> Comments are welcomed. >> >> appears to work! bq27000 is coming up now without hickups. >> >> What I can’t test is if the uevent is reasonable because we do not >> have a specific rule triggered by it in our system. >> >> So from my side we are now happy with the solution. > > So you would be ok with the following added to the patches? > > Tested-By: Dr. H. Nikolaus Schaller Yes, please add. BR, Nikolaus