From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD83C4708E for ; Wed, 7 Dec 2022 13:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbiLGNFI (ORCPT ); Wed, 7 Dec 2022 08:05:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiLGNFG (ORCPT ); Wed, 7 Dec 2022 08:05:06 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521F1554D4; Wed, 7 Dec 2022 05:05:05 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CFF5321CAD; Wed, 7 Dec 2022 13:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1670418303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1QfEziAeDcGEDzwXJANuiEADJn/6tF2TC6ZG3Sw5AU=; b=0HatBERdGReczXGRd8FOK81z1FazdvS9074cVnjDl68kk7D1QeDE67ud/6efHedB5o2qc7 yi0RzOd5CWTIGirgjlnWPZIOhSL8OmqGEWVu1l4Y4fiy8VbF4iJS3UJIcCPSMK9TI5kR+6 YKMiJMZ2dSbAyYmnppr48nYPqLASlEQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1670418303; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C1QfEziAeDcGEDzwXJANuiEADJn/6tF2TC6ZG3Sw5AU=; b=Xv2Et2gOs310IJlWOnB4TJ4oi5izH0foJ5Bpov0oX9YEf5AntHW7vWA8LHzKK3go+3bBWC GS0YqyR/pER3ODAQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id C62E9134CD; Wed, 7 Dec 2022 13:05:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 5o/mIn6PkGPqYQAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 13:05:02 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: [PATCH] bcache: Convert to use sysfs_emit()/sysfs_emit_at() APIs From: Coly Li In-Reply-To: <202212071702359325169@zte.com.cn> Date: Wed, 7 Dec 2022 21:04:50 +0800 Cc: Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <0DC3481B-747E-4874-BDD5-47016A0C4916@suse.de> References: <202212071702359325169@zte.com.cn> To: ye.xingchen@zte.com.cn X-Mailer: Apple Mail (2.3731.200.110.1.12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 2022=E5=B9=B412=E6=9C=887=E6=97=A5 17:02=EF=BC=8C =E5=86=99=E9=81=93=EF=BC=9A >=20 > From: ye xingchen >=20 > Follow the advice of the Documentation/filesystems/sysfs.rst and = show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. >=20 > Signed-off-by: ye xingchen Added to my for-next queue for Linux v6.3 merge window. Thanks. Coly Li > --- > drivers/md/bcache/sysfs.c | 31 +++++++++++++++---------------- > 1 file changed, 15 insertions(+), 16 deletions(-) >=20 > diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c > index c6f677059214..0e2c1880f60b 100644 > --- a/drivers/md/bcache/sysfs.c > +++ b/drivers/md/bcache/sysfs.c > @@ -1111,26 +1111,25 @@ SHOW(__bch_cache) >=20 > vfree(p); >=20 > - ret =3D scnprintf(buf, PAGE_SIZE, > - "Unused: %zu%%\n" > - "Clean: %zu%%\n" > - "Dirty: %zu%%\n" > - "Metadata: %zu%%\n" > - "Average: %llu\n" > - "Sectors per Q: %zu\n" > - "Quantiles: [", > - unused * 100 / (size_t) ca->sb.nbuckets, > - available * 100 / (size_t) ca->sb.nbuckets, > - dirty * 100 / (size_t) ca->sb.nbuckets, > - meta * 100 / (size_t) ca->sb.nbuckets, sum, > - n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1)); > + ret =3D sysfs_emit(buf, > + "Unused: %zu%%\n" > + "Clean: %zu%%\n" > + "Dirty: %zu%%\n" > + "Metadata: %zu%%\n" > + "Average: %llu\n" > + "Sectors per Q: %zu\n" > + "Quantiles: [", > + unused * 100 / (size_t) ca->sb.nbuckets, > + available * 100 / (size_t) ca->sb.nbuckets, > + dirty * 100 / (size_t) ca->sb.nbuckets, > + meta * 100 / (size_t) ca->sb.nbuckets, sum, > + n * ca->sb.bucket_size / (ARRAY_SIZE(q) + 1)); >=20 > for (i =3D 0; i < ARRAY_SIZE(q); i++) > - ret +=3D scnprintf(buf + ret, PAGE_SIZE - ret, > - "%u ", q[i]); > + ret +=3D sysfs_emit_at(buf, ret, "%u ", q[i]); > ret--; >=20 > - ret +=3D scnprintf(buf + ret, PAGE_SIZE - ret, "]\n"); > + ret +=3D sysfs_emit_at(buf, ret, "]\n"); >=20 > return ret; > } > --=20 > 2.25.1