linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
@ 2021-07-29 16:43 Michael Sun
  2021-07-29 19:47 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Sun @ 2021-07-29 16:43 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: chromeos-bluetooth-upstreaming, Chethan T N, Michael Sun,
	Johan Hedberg, Luiz Augusto von Dentz, Marcel Holtmann,
	linux-kernel

From: Chethan T N <chethan.tumkur.narayan@intel.com>

The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
support the Microsoft vendor extension and they are using
0xFC1E for VsMsftOpCode.

Verified on a GarfieldPeak device through bluetoothctl show

Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
Signed-off-by: Michael Sun <michaelfsun@google.com>
---

 drivers/bluetooth/btusb.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 1876a960b3dc..23cf6e98173b 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3031,6 +3031,17 @@ static int btusb_setup_intel_newgen(struct hci_dev *hdev)
 	btintel_version_info_tlv(hdev, &version);
 
 finish:
+	/* All Intel new genration controllers support the Microsoft vendor
+	 * extension are using 0xFC1E for VsMsftOpCode.
+	 */
+	switch (INTEL_HW_VARIANT(version.cnvi_bt)) {
+	case 0x17:
+	case 0x18:
+	case 0x19:
+		hci_set_msft_opcode(hdev, 0xFC1E);
+		break;
+	}
+
 	/* Set the event mask for Intel specific vendor events. This enables
 	 * a few extra events that are useful during general operation. It
 	 * does not enable any debugging related events.
-- 
2.32.0.432.gabb21c7263-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers
  2021-07-29 16:43 [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers Michael Sun
@ 2021-07-29 19:47 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-07-29 19:47 UTC (permalink / raw)
  To: Michael Sun
  Cc: linux-bluetooth, CrosBT Upstreaming, Chethan T N, Johan Hedberg,
	Luiz Augusto von Dentz, linux-kernel

Hi Michael,

> The Intel TyphoonPeak, GarfieldPeak Bluetooth controllers
> support the Microsoft vendor extension and they are using
> 0xFC1E for VsMsftOpCode.
> 
> Verified on a GarfieldPeak device through bluetoothctl show
> 
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Signed-off-by: Michael Sun <michaelfsun@google.com>
> ---
> 
> drivers/bluetooth/btusb.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)

Patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-29 19:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 16:43 [PATCH] Bluetooth: btusb: Enable MSFT extension for Intel next generation controllers Michael Sun
2021-07-29 19:47 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).