From: "Cai, Cliff" <Cliff.Cai@analog.com>
To: "Mark Brown" <broonie@opensource.wolfsonmicro.com>,
"Bryan Wu" <cooloney@kernel.org>
Cc: <liam.girdwood@wolfsonmicro.com>, <linux-kernel@vger.kernel.org>,
<alsa-devel@alsa-project.org>
Subject: RE: [PATCH 1/1] [ASOC]: AD1980 audio codec ASOC driver
Date: Tue, 13 May 2008 11:00:58 +0800 [thread overview]
Message-ID: <0F1B54C89D5F954D8535DB252AF412FA01F2EF2C@chinexm1.ad.analog.com> (raw)
In-Reply-To: <20080512115416.GB23216@sirena.org.uk>
ok,we will implement these two functions later.
Best Regards
Cliff Cai
-----Original Message-----
From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
Sent: Monday, May 12, 2008 7:54 PM
To: Bryan Wu
Cc: liam.girdwood@wolfsonmicro.com; linux-kernel@vger.kernel.org; Cliff
Cai; alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] [ASOC]: AD1980 audio codec ASOC driver
On Mon, May 12, 2008 at 06:45:12PM +0800, Bryan Wu wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
Thanks, I've applied this to the ASoC git tree. CCing in
alsa-devel@alsa-project.org - ALSA patches should go via there.
> +static int ad1980_soc_suspend(struct platform_device *pdev,
> + pm_message_t state)
> +{
> + return 0;
> +}
> +
> +static int ad1980_soc_resume(struct platform_device *pdev) {
> + return 0;
> +}
Are you sure about these? I would expect the suspend and resume
functions to either do some register writes or be omitted if they don't
do anything. Standard AC97 codecs would have some power management via
register 0x26 if they were doing anything.
next prev parent reply other threads:[~2008-05-13 2:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:45 [PATCH 1/1] [ASOC]: AD1980 audio codec ASOC driver Bryan Wu
2008-05-12 11:54 ` Mark Brown
2008-05-12 11:56 ` Mark Brown
2008-05-13 3:00 ` Cai, Cliff [this message]
2008-05-13 14:01 ` Mark Brown
2008-05-13 15:07 ` Bryan Wu
2008-05-13 15:24 ` Mark Brown
2008-05-13 10:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F1B54C89D5F954D8535DB252AF412FA01F2EF2C@chinexm1.ad.analog.com \
--to=cliff.cai@analog.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cooloney@kernel.org \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).