From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB93C4338F for ; Thu, 5 Aug 2021 16:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A420161156 for ; Thu, 5 Aug 2021 16:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240451AbhHEQDP (ORCPT ); Thu, 5 Aug 2021 12:03:15 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.82]:8248 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242882AbhHEQC7 (ORCPT ); Thu, 5 Aug 2021 12:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1628179296; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=kz7en5zl8fiteD+7Oum9C7YsAgoEzeXk8l+oEFfizAo=; b=sZu6BlP6OpE75L0Oqdx3CmyEW36PC4r0dt8PPRWad0sdlneMMt5MUP+cvZ+Ua/RBCo uORUfbbbf5w294rJ66uvHvvCRp2oy7wk1DtMqKhX0eV5pCTD2N78eLD9vZl0hmo3QZKB uLmUSfp4poDsYCRIgvtBLu4iYG7KbNFdfoGt1/wEaNAZofwFoZTfCV1U7/qj0a69nV+l hLG1LqSsVLC9I+tELJ6I5xsIboL2oC7RWv8ipZt2BtsfSwv0usc/48U1l9LUjnst2K8e 7kSCGNG3qtcyT/W4UvOcdcGmBY78g7e53FCkYlIIHQ0DNxhlpvAvfHqo6CPS7+nEFe5b R1qQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw9iZeHWElw4rovw==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.31.0 DYNA|AUTH) with ESMTPSA id Q02727x75G1W7WQ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 5 Aug 2021 18:01:32 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v2 3/8] drm/ingenic: Add support for JZ4780 and HDMI output From: "H. Nikolaus Schaller" In-Reply-To: Date: Thu, 5 Aug 2021 18:01:31 +0200 Cc: Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Ezequiel Garcia , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Paul Boddie , Jonas Karlman , dri-devel@lists.freedesktop.org Content-Transfer-Encoding: quoted-printable Message-Id: <0F96C1D5-D98B-4461-B691-20A0C3C38C18@goldelico.com> References: <263a207d2aeb8bc95aa8464212dcc9b225548f4f.1628172477.git.hns@goldelico.com> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, > Am 05.08.2021 um 17:22 schrieb Paul Cercueil : >=20 > Hi Nikolaus & Paul, >=20 > Le jeu., ao=C3=BBt 5 2021 at 16:07:52 +0200, H. Nikolaus Schaller = a =C3=A9crit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This SoC uses 8-byte descriptors which extend the current >> 4-byte descriptors used for other Ingenic SoCs. >> Also, add special handling for HDMI-A connectors. >> For some reason, only the primary planes are working >> properly. As soon as the overlay plane is enabled >> things go south :P >> Tested on MIPS Creator CI20 board. >> Signed-off-by: Paul Boddie >> Signed-off-by: Ezequiel Garcia >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 163 = ++++++++++++++++++++-- ... snip ... >=20 > We already have these in ingenic-drm.h... >=20 > Please only add the macros that you need and are missing. >=20 > Cheers, > -Paul all are valid comments. We'll add them for v3 or find answers if some code fragments are needed (even if we don't know why) or not. BR and thanks, Nikolaus