From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D82FDC433B4 for ; Fri, 23 Apr 2021 07:09:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6FEA613F6 for ; Fri, 23 Apr 2021 07:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240905AbhDWHJk (ORCPT ); Fri, 23 Apr 2021 03:09:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37505 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbhDWHJg (ORCPT ); Fri, 23 Apr 2021 03:09:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619161740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q8ibsUJr2Xw/0Bx+47uUdT7BpjL9CbRIh33qYka8yhk=; b=G63DP9uNTp1EdHBbtthf0ZcBi3qp0brUoYzACYBg1UqxQVvmo4qAZv+GxzfLQJqrTvDRLZ r0ecJlY7Pax0uZpNV/S6ryCxs078lJ5UNgktz1j5tJqZthgV1MC9GicA6aKzQDCrK67ydv 5MITLMRsBDxP7nZ8tG86s1OByUYDxmg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-dKJb_9npP4GxitKr2F07hw-1; Fri, 23 Apr 2021 03:08:58 -0400 X-MC-Unique: dKJb_9npP4GxitKr2F07hw-1 Received: by mail-ed1-f69.google.com with SMTP id i25-20020a50fc190000b0290384fe0dab00so12539458edr.6 for ; Fri, 23 Apr 2021 00:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q8ibsUJr2Xw/0Bx+47uUdT7BpjL9CbRIh33qYka8yhk=; b=A6tEct89koT2dERBv9LdDM/Lzi+ZvT5xYUqkP4BlZWNglShJhIOZim9GiUa17E9+cb XQCVVL+QfAfOwMFKbebwE/sh3l3s0t7U5Dwx0sQ+K0MPQWOe4D99tZYPC/6wnAN3ymf0 ca4ItOA+iE4r4CedcpahSq8wf1xpFK0RPIbwZ/kl/Uvh/IVQsQqxAqgBTMGYFh+h4vIM 1rKI+eBrZ1Zn8as3tVXML2rMAtOcpaaWte2yMz+sa0bT30uJ02P9mI3d6Uo+w6VgogY3 fgpBj9JHDu9R4uMzHmpUPT1roGd4dRq5zBbIZ+e30HmMc1BBEaSzgK5sdNbjRT5LgRua N2QA== X-Gm-Message-State: AOAM5320za8Dt869ptEy3qtNXg5FBxbXbUOJhGDoZWvhFmhbqxatpZsS Pn5Nitb7ZFWk5CjzwsG2+X7izMmdGRMC/g6fTusYNlbHSHbnkbem1k4z8Kn2v46BuJkx47rUhCs mK19eSNlkXS8VLdI3jdJDE/le X-Received: by 2002:a17:906:8407:: with SMTP id n7mr2602600ejx.264.1619161737479; Fri, 23 Apr 2021 00:08:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKqvDTxTMHU32SuNhtPSengJjdOtcKbAFGUrVKJrR2v+QuY2jmt97ToVycVtIsglBSI71ryw== X-Received: by 2002:a17:906:8407:: with SMTP id n7mr2602582ejx.264.1619161737244; Fri, 23 Apr 2021 00:08:57 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id p4sm3890045edr.43.2021.04.23.00.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Apr 2021 00:08:56 -0700 (PDT) Subject: Re: [PATCH v5 03/15] KVM: SVM: Disable SEV/SEV-ES if NPT is disabled To: Sean Christopherson Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Wei Huang , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Tom Lendacky , Brijesh Singh References: <20210422021125.3417167-1-seanjc@google.com> <20210422021125.3417167-4-seanjc@google.com> <5e8a2d7d-67de-eef4-ab19-33294920f50c@redhat.com> <882d8bb4-8d40-1b4d-0742-4a4f2c307e5b@redhat.com> From: Paolo Bonzini Message-ID: <0a00ee34-965a-0ee1-1e2c-7fda8e21ec9e@redhat.com> Date: Fri, 23 Apr 2021 09:08:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/21 20:11, Sean Christopherson wrote: >> Yes, you're right. NPT is easy but we would have to guess what the spec >> would say about MAXPHYADDR, while nNPT would require the stacking of a PML5. >> Either way, blocking KVM is the easiest thing todo. > How about I fold that into the s/lm_root/pml4_root rename[*]? I.e. make the > blocking of PML5 a functional change, and the rename an opportunistic change? > > [*]https://lkml.kernel.org/r/20210318201131.3242619-1-seanjc@google.com > Yes, that's a good plan. Thanks, Paolo