From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 02/10] arm64: dts: qcom: Add base SM8550 dtsi
Date: Thu, 24 Nov 2022 16:40:52 +0100 [thread overview]
Message-ID: <0a119446-4ec1-46ce-68e5-f177f9cb49e3@linaro.org> (raw)
In-Reply-To: <351fa466-90cb-b73f-a2a4-749bc3529e22@quicinc.com>
On 24.11.2022 16:39, Sai Prakash Ranjan wrote:
> Hi,
>
> On 11/24/2022 7:26 PM, Abel Vesa wrote:
>> Add base dtsi for SM8550 SoC and includes base description of
>> CPUs, GCC, RPMHCC, UART, interrupt controller, TLMM, reserved
>> memory, RPMh PD, TCSRCC, ITS, IPCC, AOSS QMP, LLCC, cpufreq,
>> interconnect, thermal sensor, cpu cooling maps and SMMU nodes
>> which helps boot to shell with console on boards with this SoC.
>>
>> Co-developed-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>
> <snip>...
>
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 12 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
>
> This last interrupt must be Hypervisor physical irq(10) and 12 is Hyp virtual irq, so please change it to 10. I guess you got this from downstream but it's not right and they don't boot kernel in EL2.
Does non-CrOS 8550 FW allow Linux to boot in EL2?
Konrad
>
> Thanks,
> Sai
next prev parent reply other threads:[~2022-11-24 15:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 13:56 [PATCH v2 00/10] arm64: dts: Add base device tree files for SM8550 Abel Vesa
2022-11-24 13:56 ` [PATCH v2 01/10] dt-bindings: arm: qcom: Document SM8550 SoC and boards Abel Vesa
2022-11-24 13:56 ` [PATCH v2 02/10] arm64: dts: qcom: Add base SM8550 dtsi Abel Vesa
2022-11-24 14:41 ` Konrad Dybcio
2022-11-24 15:39 ` Sai Prakash Ranjan
2022-11-24 15:40 ` Konrad Dybcio [this message]
2022-11-24 15:54 ` Sai Prakash Ranjan
2022-11-24 13:56 ` [PATCH v2 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi Abel Vesa
2022-11-24 13:56 ` [PATCH v2 04/10] arm64: dts: qcom: Add PM8550 " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 05/10] arm64: dts: qcom: Add PM8550b " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 06/10] arm64: dts: qcom: Add PM8550ve " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 07/10] arm64: dts: qcom: Add PM8550vs " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 08/10] arm64: dts: qcom: Add PMK8550 " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 09/10] arm64: dts: qcom: Add PMR735d " Abel Vesa
2022-11-24 13:56 ` [PATCH v2 10/10] arm64: dts: qcom: Add base SM8550 MTP dts Abel Vesa
2022-11-24 14:43 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a119446-4ec1-46ce-68e5-f177f9cb49e3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_saipraka@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).