From: Roger Quadros <rogerq@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Sriram Dash <sriram.dash@nxp.com>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <mathias.nyman@intel.com>,
<gregkh@linuxfoundation.org>, <suresh.gupta@nxp.com>,
<felipe.balbi@linux.intel.com>, <pku.leo@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v5 4/6] usb: xhci: use bus->sysdev for DMA configuration
Date: Thu, 12 Jan 2017 10:38:30 +0200 [thread overview]
Message-ID: <0a1a4328-fea3-a7fb-2c1b-15dbf77053b6@ti.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1701111008240.1900-100000@iolanthe.rowland.org>
Mathias,
On 11/01/17 17:08, Alan Stern wrote:
> On Wed, 11 Jan 2017, Mathias Nyman wrote:
>
>> On 17.11.2016 13:43, Sriram Dash wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> For xhci-hcd platform device, all the DMA parameters are not
>>> configured properly, notably dma ops for dwc3 devices. So, set
>>> the dma for xhci from sysdev. sysdev is pointing to device that
>>> is known to the system firmware or hardware.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>>> Tested-by: Baolin Wang <baolin.wang@linaro.org>
>>> ---
>>
>> ...
>>
>>> + /*
>>> + * sysdev must point to a device that is known to the system firmware
>>> + * or PCI hardware. We handle these three cases here:
>>> + * 1. xhci_plat comes from firmware
>>> + * 2. xhci_plat is child of a device from firmware (dwc3-plat)
>>> + * 3. xhci_plat is grandchild of a pci device (dwc3-pci)
>>> + */
>>> + sysdev = &pdev->dev;
>>> + if (sysdev->parent && !sysdev->of_node && sysdev->parent->of_node)
>>> + sysdev = sysdev->parent;
>>> +#ifdef CONFIG_PCI
>>> + else if (sysdev->parent && sysdev->parent->parent &&
>>> + sysdev->parent->parent->bus == &pci_bus_type)
>>> + sysdev = sysdev->parent->parent;
>>> +#endif
>>> +
>>
>> Not maybe the the ideal situation here, and looks really tailored to make PCI dwc3
>> controllers with xhci support work.
>>
>> Was there some reason child devices can't automatically inherit the dma mask from the parents,
>> forcing us to dig it from grandparents?
>>
>> Anyway, looks like the dwc3 part is already in 4.10-rc,
>> If Greg and Alan want to take this series that's fine by me
>
> I have no objections.
>
> Alan Stern
>
>> I haven't tested that it won't break anything on PCI XHCI controllers though
>>
>> -Mathias
Are you going to pick all the remaining patches from this series (i.e. 1 to 4)?
That should fix the warning that people are seeing on v4.10-rc.
cheers,
roger
next prev parent reply other threads:[~2017-01-12 8:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 11:43 [PATCH v5 0/6] inherit dma configuration from parent dev Sriram Dash
2016-11-17 11:43 ` [PATCH v5 1/6] usb: separate out sysdev pointer from usb_bus Sriram Dash
2016-12-03 0:19 ` Brian Norris
2017-01-06 19:33 ` Grygorii Strashko
2016-12-13 16:09 ` [v5,1/6] " Alexander Sverdlin
2016-11-17 11:43 ` [PATCH v5 2/6] usb: chipidea: use bus->sysdev for DMA configuration Sriram Dash
2016-11-17 11:43 ` [PATCH v5 3/6] usb: ehci: fsl: " Sriram Dash
2016-11-17 11:43 ` [PATCH v5 4/6] usb: xhci: " Sriram Dash
2016-12-09 11:56 ` Roger Quadros
2016-12-13 16:09 ` [v5,4/6] " Alexander Sverdlin
2017-01-11 14:21 ` [PATCH v5 4/6] " Mathias Nyman
2017-01-11 15:08 ` Alan Stern
2017-01-12 8:38 ` Roger Quadros [this message]
2017-01-18 11:58 ` Mathias Nyman
2017-01-19 9:22 ` Greg KH
2017-01-19 11:33 ` Mathias Nyman
2016-11-17 11:43 ` [PATCH v5 5/6] usb: dwc3: " Sriram Dash
2016-12-13 16:09 ` [v5,5/6] " Alexander Sverdlin
2016-11-17 11:43 ` [PATCH v5 6/6] usb: dwc3: Do not set dma coherent mask Sriram Dash
2016-12-13 16:09 ` [v5,6/6] " Alexander Sverdlin
2016-12-22 6:23 ` [PATCH v5 0/6] inherit dma configuration from parent dev Vivek Gautam
2017-01-05 15:21 ` Roger Quadros
2017-01-05 17:16 ` Greg KH
2017-01-10 12:11 ` Roger Quadros
2017-01-11 21:32 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a1a4328-fea3-a7fb-2c1b-15dbf77053b6@ti.com \
--to=rogerq@ti.com \
--cc=arnd@arndb.de \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=pku.leo@gmail.com \
--cc=sriram.dash@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=suresh.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).