linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Aaron Lu'" <aaron.lu@intel.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Cc: "'Dave Hansen'" <dave.hansen@intel.com>,
	"'Tim Chen'" <tim.c.chen@intel.com>,
	"'Andrew Morton'" <akpm@linux-foundation.org>,
	"'Ying Huang'" <ying.huang@intel.com>
Subject: Re: [PATCH v2 2/5] mm: parallel free pages
Date: Wed, 15 Mar 2017 17:42:42 +0800	[thread overview]
Message-ID: <0a2501d29d70$7eb0f530$7c12df90$@alibaba-inc.com> (raw)
In-Reply-To: <1489568404-7817-3-git-send-email-aaron.lu@intel.com>


On March 15, 2017 5:00 PM Aaron Lu wrote: 
>  void tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
>  {
> +	struct batch_free_struct *batch_free, *n;
> +
s/*n/*next/

>  	tlb_flush_mmu(tlb);
> 
>  	/* keep the page table cache within bounds */
>  	check_pgt_cache();
> 
> +	list_for_each_entry_safe(batch_free, n, &tlb->worker_list, list) {
> +		flush_work(&batch_free->work);

Not sure, list_del before free?

> +		kfree(batch_free);
> +	}
> +
>  	tlb_flush_mmu_free_batches(tlb->local.next, true);
>  	tlb->local.next = NULL;
>  }

  reply	other threads:[~2017-03-15  9:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  8:59 [PATCH v2 0/5] mm: support parallel free of memory Aaron Lu
2017-03-15  9:00 ` [PATCH v2 1/5] mm: add tlb_flush_mmu_free_batches Aaron Lu
2017-03-15  9:00 ` [PATCH v2 2/5] mm: parallel free pages Aaron Lu
2017-03-15  9:42   ` Hillf Danton [this message]
2017-03-15 11:54     ` Aaron Lu
2017-03-15  9:00 ` [PATCH v2 3/5] mm: use a dedicated workqueue for the free workers Aaron Lu
2017-03-22  6:33   ` Minchan Kim
2017-03-22  8:41     ` Aaron Lu
2017-03-22  8:55       ` Minchan Kim
2017-03-22 13:43         ` Aaron Lu
2017-03-23  5:53           ` Minchan Kim
2017-03-23 15:38       ` Dave Hansen
2017-03-24 12:37         ` Aaron Lu
2017-03-15  9:00 ` [PATCH v2 4/5] mm: add force_free_pages in zap_pte_range Aaron Lu
2017-03-15  9:00 ` [PATCH v2 5/5] mm: add debugfs interface for parallel free tuning Aaron Lu
2017-03-15 14:18 ` [PATCH v2 0/5] mm: support parallel free of memory Michal Hocko
2017-03-15 15:44   ` Aaron Lu
2017-03-15 16:28     ` Michal Hocko
2017-03-15 21:38       ` Tim Chen
2017-03-16  9:07         ` Michal Hocko
2017-03-16 18:36           ` Tim Chen
2017-03-17  7:47             ` Michal Hocko
2017-03-17  8:07               ` Minchan Kim
2017-03-17 12:33               ` Aaron Lu
2017-03-17 12:59                 ` Michal Hocko
2017-03-17 13:16                 ` Peter Zijlstra
2017-03-17 12:53               ` Peter Zijlstra
2017-03-17 13:05                 ` Michal Hocko
2017-03-21 14:54           ` Dave Hansen
2017-03-22  8:02             ` Aaron Lu
2017-03-24  7:04             ` Aaron Lu
2017-03-21 15:18           ` Tim Chen
2017-03-16  6:54       ` Aaron Lu
2017-03-16  7:34       ` Aaron Lu
2017-03-16 13:51         ` Aaron Lu
2017-03-16 14:14           ` Aaron Lu
2017-03-15 14:56 ` Vlastimil Babka
2017-03-15 15:50   ` Aaron Lu
2017-03-17  3:10   ` Aaron Lu
2017-03-16 19:38 ` Alex Thorlton
2017-03-17  2:21   ` Aaron Lu
2017-03-20 19:15     ` Alex Thorlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0a2501d29d70$7eb0f530$7c12df90$@alibaba-inc.com' \
    --to=hillf.zj@alibaba-inc.com \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).