From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BD8C4338F for ; Wed, 4 Aug 2021 08:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F2D860F02 for ; Wed, 4 Aug 2021 08:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236434AbhHDI2M (ORCPT ); Wed, 4 Aug 2021 04:28:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56397 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236401AbhHDI2K (ORCPT ); Wed, 4 Aug 2021 04:28:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628065677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VzZ2fz11QFkhGxgNVXLaPyQv4vbgyLKy/JcMqXEwSCE=; b=G6m8oA3op9pu+76PZVZ8PHY/jWhpglbO+cAwI3S0z/PqxPFwTv9Yh8r2LfVlqWOgDH06C9 lNbB9mQpPk0xLukYBxK6dOhlmCf/o+NX4XoHUl/j5GuS5ot+RyDfjnu6KNO3NzUz1XsQ1k KzJZDVxJTgj6V6k2lDzDLfMVBWj6Lj8= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-Rwuq0cj2P8-j5Te2UXN8vA-1; Wed, 04 Aug 2021 04:27:56 -0400 X-MC-Unique: Rwuq0cj2P8-j5Te2UXN8vA-1 Received: by mail-pj1-f72.google.com with SMTP id s20-20020a17090a5d14b0290177ee10728cso1814398pji.9 for ; Wed, 04 Aug 2021 01:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VzZ2fz11QFkhGxgNVXLaPyQv4vbgyLKy/JcMqXEwSCE=; b=EY9R4U/9uwIeOt4KUUB0xelOLvr2UktjhGWHh4QKVQJD3cgeWDu7aJGh5+agshimhS 5G77VrbT/oqn1YyaNajFCfu/C7oy6p5wFE5zOia/y2tNtlktN5uQMR0GHkM35VlISDJD zUkFdAwB6+9Vr7mxy1H/2nUu0BAgYZ1yBDdh7yF4+jfkMlalM2YKsDxWH4bqDFNvLVBK XIOeSWX+RjM6YWiJr6Tf91umX73jepeMrgnNuljbuiiRWFS10TxHfQcttSoIy6ptGZq0 ONSQAS750KF5n1aJmN3LnCZQQQM0Cn+DHXCGfWNKhAeND1Q5EIfP3RpQqCB5pkJkvWra zH9A== X-Gm-Message-State: AOAM530JtSAh7vaB2IzpbWICG3nf8zk/imuCOjwJ/oMWMXLBW6YRO+Ww pHBn8z1KMTac7gcYDv7AsC5P0Rg9IAeMIE8NV0CvHK+Bm9+SFphuod4VNbQXkoFEAF57fdawfRm pWo5ITbJlMXSCaBgpouH2HIY4Q2BtHKLXlDhQli3m3nYk1mdi2T8WQNnAFkGfqZ2v7Oogi9w/AW fz X-Received: by 2002:a65:620a:: with SMTP id d10mr1146374pgv.120.1628065675502; Wed, 04 Aug 2021 01:27:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXILAtwY28td6fRSflYoyigX2PjP4ZVbOPHaGCmnbiB1lEKAblvPX4KIAKHqSTrKqVGtkG2Q== X-Received: by 2002:a65:620a:: with SMTP id d10mr1146334pgv.120.1628065675198; Wed, 04 Aug 2021 01:27:55 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id l2sm1714190pfc.157.2021.08.04.01.27.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Aug 2021 01:27:54 -0700 (PDT) Subject: Re: [PATCH v10 02/17] file: Export receive_fd() to modules To: Yongji Xie Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=c3=a4?= , Dan Carpenter , joro@8bytes.org, Greg KH , He Zhe , Liu Xiaodong , Joe Perches , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-3-xieyongji@bytedance.com> From: Jason Wang Message-ID: <0a37dce4-0012-c2d1-bb06-5e9409815b93@redhat.com> Date: Wed, 4 Aug 2021 16:27:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/8/3 下午5:01, Yongji Xie 写道: > On Tue, Aug 3, 2021 at 3:46 PM Jason Wang wrote: >> >> 在 2021/7/29 下午3:34, Xie Yongji 写道: >>> Export receive_fd() so that some modules can use >>> it to pass file descriptor between processes without >>> missing any security stuffs. >>> >>> Signed-off-by: Xie Yongji >>> --- >>> fs/file.c | 6 ++++++ >>> include/linux/file.h | 7 +++---- >>> 2 files changed, 9 insertions(+), 4 deletions(-) >>> >>> diff --git a/fs/file.c b/fs/file.c >>> index 86dc9956af32..210e540672aa 100644 >>> --- a/fs/file.c >>> +++ b/fs/file.c >>> @@ -1134,6 +1134,12 @@ int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags) >>> return new_fd; >>> } >>> >>> +int receive_fd(struct file *file, unsigned int o_flags) >>> +{ >>> + return __receive_fd(file, NULL, o_flags); >> >> Any reason that receive_fd_user() can live in the file.h? >> > Since no modules use it. > > Thanks, > Yongji Ok. Acked-by: Jason Wang >