From: Sibi Sankar <sibis@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org,
andy.gross@linaro.org, david.brown@linaro.org,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v2 3/9] soc: qcom: rpmpd: Modify corner defining macros
Date: Wed, 27 Mar 2019 18:58:22 +0530 [thread overview]
Message-ID: <0a3a6d819078cad74468c018efea586e@codeaurora.org> (raw)
In-Reply-To: <6d1453af-b01f-9e5a-4c9a-b2af00d1f05f@codeaurora.org>
On 2019-03-25 09:37, Rajendra Nayak wrote:
> On 3/24/2019 11:20 PM, Sibi Sankar wrote:
>> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>>
>> QCS404 uses individual resource type magic for each power-domain, so
>> adjust the macros slightly to make them reusable for this.
>>
>> [sibi: Extend rpmpd corner pair to a generic rpmpd pair]
>
> This needs to be right above your SoB I think.
will re-order them in v3
>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/soc/qcom/rpmpd.c | 39
>> +++++++++++++++++----------------------
>> 1 file changed, 17 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
>> index 71fdfafad2ea..17cd59d1ac3b 100644
>> --- a/drivers/soc/qcom/rpmpd.c
>> +++ b/drivers/soc/qcom/rpmpd.c
>> @@ -17,8 +17,8 @@
>> #define domain_to_rpmpd(domain) container_of(domain, struct rpmpd,
>> pd)
>> /* Resource types */
>> -#define RPMPD_SMPA 0x61706d73
>> -#define RPMPD_LDOA 0x616f646c
>> +#define RPMPD_SMPA 0x61706d73 /* smpa */
>> +#define RPMPD_LDOA 0x616f646c /* ldoa */
>> /* Operation Keys */
>> #define KEY_CORNER 0x6e726f63 /* corn */
>> @@ -27,46 +27,41 @@
>> #define MAX_RPMPD_STATE 6
>> -#define DEFINE_RPMPD_CORNER_SMPA(_platform, _name, _active,
>> r_id) \
>> +#define DEFINE_RPMPD_PAIR(_platform, _name, _active, r_type, r_key, \
>> + r_id) \
>> static struct rpmpd _platform##_##_active; \
>> static struct rpmpd _platform##_##_name = { \
>> .pd = { .name = #_name, }, \
>> .peer = &_platform##_##_active, \
>> - .res_type = RPMPD_SMPA, \
>> + .res_type = RPMPD_##r_type, \
>> .res_id = r_id, \
>> - .key = KEY_CORNER, \
>> + .key = KEY_##r_key, \
>> }; \
>> static struct rpmpd _platform##_##_active = { \
>> .pd = { .name = #_active, }, \
>> .peer = &_platform##_##_name, \
>> .active_only = true, \
>> - .res_type = RPMPD_SMPA, \
>> + .res_type = RPMPD_##r_type, \
>> .res_id = r_id, \
>> - .key = KEY_CORNER, \
>> + .key = KEY_##r_key, \
>> }
>> -#define DEFINE_RPMPD_CORNER_LDOA(_platform, _name, r_id) \
>> +#define DEFINE_RPMPD_CORNER(_platform, _name, r_type, r_id) \
>> static struct rpmpd _platform##_##_name = { \
>> .pd = { .name = #_name, }, \
>> - .res_type = RPMPD_LDOA, \
>> + .res_type = RPMPD_##r_type, \
>> .res_id = r_id, \
>> .key = KEY_CORNER, \
>> }
>> -#define DEFINE_RPMPD_VFC(_platform, _name, r_id, r_type) \
>> +#define DEFINE_RPMPD_VFC(_platform, _name, r_type, r_id) \
>> static struct rpmpd _platform##_##_name = { \
>> .pd = { .name = #_name, }, \
>> - .res_type = r_type, \
>> + .res_type = RPMPD_##r_type, \
>> .res_id = r_id, \
>> .key = KEY_FLOOR_CORNER, \
>> }
>> -#define DEFINE_RPMPD_VFC_SMPA(_platform, _name, r_id) \
>> - DEFINE_RPMPD_VFC(_platform, _name, r_id, RPMPD_SMPA)
>> -
>> -#define DEFINE_RPMPD_VFC_LDOA(_platform, _name, r_id) \
>> - DEFINE_RPMPD_VFC(_platform, _name, r_id, RPMPD_LDOA)
>> -
>> struct rpmpd_req {
>> __le32 key;
>> __le32 nbytes;
>> @@ -96,12 +91,12 @@ struct rpmpd_desc {
>> static DEFINE_MUTEX(rpmpd_lock);
>> /* msm8996 RPM Power domains */
>> -DEFINE_RPMPD_CORNER_SMPA(msm8996, vddcx, vddcx_ao, 1);
>> -DEFINE_RPMPD_CORNER_SMPA(msm8996, vddmx, vddmx_ao, 2);
>> -DEFINE_RPMPD_CORNER_LDOA(msm8996, vddsscx, 26);
>> +DEFINE_RPMPD_PAIR(msm8996, vddcx, vddcx_ao, SMPA, CORNER, 1);
>> +DEFINE_RPMPD_PAIR(msm8996, vddmx, vddmx_ao, SMPA, CORNER, 2);
>> +DEFINE_RPMPD_CORNER(msm8996, vddsscx, LDOA, 26);
>> -DEFINE_RPMPD_VFC_SMPA(msm8996, vddcx_vfc, 1);
>> -DEFINE_RPMPD_VFC_LDOA(msm8996, vddsscx_vfc, 26);
>> +DEFINE_RPMPD_VFC(msm8996, vddcx_vfc, SMPA, 1);
>> +DEFINE_RPMPD_VFC(msm8996, vddsscx_vfc, LDOA, 26);
>> static struct rpmpd *msm8996_rpmpds[] = {
>> [MSM8996_VDDCX] = &msm8996_vddcx,
>>
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-03-27 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 17:49 [PATCH v2 0/9] RPMPD for QCS404 and MSM8998 Sibi Sankar
2019-03-24 17:49 ` [PATCH v2 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state Sibi Sankar
2019-03-25 4:03 ` Rajendra Nayak
2019-03-27 13:26 ` Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 2/9] soc: qcom: rpmpd: Add support to set rpmpd state to max Sibi Sankar
2019-03-25 4:06 ` Rajendra Nayak
2019-03-27 13:27 ` Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 3/9] soc: qcom: rpmpd: Modify corner defining macros Sibi Sankar
2019-03-25 4:07 ` Rajendra Nayak
2019-03-27 13:28 ` Sibi Sankar [this message]
2019-03-24 17:50 ` [PATCH v2 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404 Sibi Sankar
2019-03-25 4:21 ` Rajendra Nayak
2019-03-27 13:25 ` Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 5/9] soc: qcom: rpmpd: Add QCS404 power-domains Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 6/9] arm64: dts: qcom: qcs404: Add rpmpd node Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 7/9] dt-bindings: power: Add rpm power domain bindings for msm8998 Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Sibi Sankar
2019-03-24 17:50 ` [PATCH v2 9/9] arm64: dts: qcom: msm8998: Add rpmpd node Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a3a6d819078cad74468c018efea586e@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).