From: Jason-JH Lin <jason-jh.lin@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Fabien Parent <fparent@baylibre.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, CK Hu <ck.hu@mediatek.com>,
Rex-BC Chen <rex-bc.chen@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH] dt-bindings: arm: mediatek: mmsys: refine power and gce properties
Date: Fri, 29 Apr 2022 15:54:41 +0800 [thread overview]
Message-ID: <0a43e9787c8e4886b361268a58e755afbf81be1d.camel@mediatek.com> (raw)
In-Reply-To: <9779588a-5bda-ea82-64a0-c13d48d89eff@linaro.org>
Hi Krzysztof,
Thanks for the reviews.
On Fri, 2022-04-29 at 07:55 +0200, Krzysztof Kozlowski wrote:
> On 29/04/2022 06:10, Jason-JH Lin wrote:
> > Yes, we cannot have infinite number for this, but we can use not
> > only
> > one mbox channel for one mmsys.
> >
> > Its maximum number is equal to GCE HW thread number.
> > The maximum number in mt8195 is 24 and mt8173 is 16.
> >
> > But we currently using 1.
> > So I'm not sure if I need to set the maxItems for this?
>
> Yes. 24 for mt8195 and 16 for mt8173.
>
OK, I'll add maxItems: 24.
> >
> > >
> > > > description:
> > > > - Using mailbox to communicate with GCE, it should have
> > > > this
> > > > - property and list of phandle, mailbox specifiers. See
> > > > - Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > > > for
> > > > details.
> > > > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > + If using mailbox to communicate with GCE, it should have
> > > > this
> > > > + property. GCE will help configure the hardware settings
> > > > for
> > > > the
> > > > + current mmsys data pipeline.
> > > >
> > > > mediatek,gce-client-reg:
> > > > - description:
> > > > - The register of client driver can be configured by gce
> > > > with
> > > > 4 arguments
> > > > - defined in this property, such as phandle of gce, subsys
> > > > id,
> > > > - register offset and size.
> > > > - Each subsys id is mapping to a base address of display
> > > > function blocks
> > > > - register which is defined in the gce header
> > > > - include/dt-bindings/gce/<chip>-gce.h.
> > > > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > >
> > > Why removing ref? Does your binding work after such change?
> >
> > I removed it unexpectedly, I'll add it back.
>
> Just be sure you test it before submitting...
>
I'm sorry about this.
I think something wrong in my local scanning environment.
I'll fix this and test it before submitting the next version.
Regards,
Jason-JH.Lin
>
> Best regards,
> Krzysztof
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!3EBAk7zcr3iMc-Todq-efcLmYCZNkxH9gYnUmY1tHbPiVm9yNYhrI-Yj0I16f8jGnA6B$
>
--
Jason-JH Lin <jason-jh.lin@mediatek.com>
next prev parent reply other threads:[~2022-04-29 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220428012715.2619-1-jason-jh.lin@mediatek.com>
2022-04-28 7:16 ` [PATCH] dt-bindings: arm: mediatek: mmsys: refine power and gce properties Krzysztof Kozlowski
2022-04-29 4:10 ` Jason-JH Lin
2022-04-29 5:55 ` Krzysztof Kozlowski
2022-04-29 7:54 ` Jason-JH Lin [this message]
2022-04-29 20:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a43e9787c8e4886b361268a58e755afbf81be1d.camel@mediatek.com \
--to=jason-jh.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).