From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema
Date: Fri, 8 Apr 2022 12:59:49 +0300 [thread overview]
Message-ID: <0a6007fe-aa5e-fc2e-bf3a-fd877deebee3@ti.com> (raw)
In-Reply-To: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org>
On 07/04/2022 17:31, Krzysztof Kozlowski wrote:
> The node names should be generic and SPI NOR dtschema expects "flash".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2g-ice.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
> index 66fec5f5d081..8f49883a675e 100644
> --- a/arch/arm/boot/dts/keystone-k2e-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
> @@ -137,7 +137,7 @@ partition@180000 {
> };
>
> &spi0 {
> - nor_flash: n25q128a11@0 {
> + nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "Micron,n25q128a11";
> diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
> index d800f26b6275..88be868cf71e 100644
> --- a/arch/arm/boot/dts/keystone-k2g-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
> @@ -392,7 +392,7 @@ &qspi {
> pinctrl-0 = <&qspi_pins>;
> cdns,rclk-en;
>
> - flash0: m25p80@0 {
> + flash0: flash@0 {
> compatible = "s25fl512s", "jedec,spi-nor";
> reg = <0>;
> spi-tx-bus-width = <1>;
> diff --git a/arch/arm/boot/dts/keystone-k2g-ice.dts b/arch/arm/boot/dts/keystone-k2g-ice.dts
> index 2a2d38cf0fff..bd84d7f0f2fe 100644
> --- a/arch/arm/boot/dts/keystone-k2g-ice.dts
> +++ b/arch/arm/boot/dts/keystone-k2g-ice.dts
> @@ -325,7 +325,7 @@ &qspi {
> cdns,rclk-en;
> status = "okay";
>
> - flash0: m25p80@0 {
> + flash0: flash@0 {
> compatible = "s25fl256s1", "jedec,spi-nor";
> reg = <0>;
> spi-tx-bus-width = <1>;
> diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> index ad4e22afe133..f968af0bfad3 100644
> --- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
> @@ -161,7 +161,7 @@ dtt@50 {
> };
>
> &spi0 {
> - nor_flash: n25q128a11@0 {
> + nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "Micron,n25q128a11";
> diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
> index e200533d26a4..32619b3c5804 100644
> --- a/arch/arm/boot/dts/keystone-k2l-evm.dts
> +++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
> @@ -110,7 +110,7 @@ partition@180000 {
> };
>
> &spi0 {
> - nor_flash: n25q128a11@0 {
> + nor_flash: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "Micron,n25q128a11";
Thank you
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
Grygorii, Ukraine
prev parent reply other threads:[~2022-04-08 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:31 [PATCH 1/2] ARM: dts: keystone: align SPI NOR node name with dtschema Krzysztof Kozlowski
2022-04-07 14:31 ` [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Krzysztof Kozlowski
2022-04-08 9:58 ` Grygorii Strashko
2022-04-15 18:54 ` Nishanth Menon
2022-04-17 17:58 ` Krzysztof Kozlowski
2022-04-08 9:59 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a6007fe-aa5e-fc2e-bf3a-fd877deebee3@ti.com \
--to=grygorii.strashko@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).