From: <Tudor.Ambarus@microchip.com>
To: <code@reto-schneider.ch>, <linux-mtd@lists.infradead.org>
Cc: <sr@denx.de>, <reto.schneider@husqvarnagroup.com>,
<miquel.raynal@bootlin.com>, <p.yadav@ti.com>, <richard@nod.at>,
<vigneshr@ti.com>, <linux-kernel@vger.kernel.org>,
<michael@walle.cc>
Subject: Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C
Date: Mon, 28 Jun 2021 05:17:11 +0000 [thread overview]
Message-ID: <0a9ea6f8-b8d1-cda8-e2c0-652adf957a90@microchip.com> (raw)
In-Reply-To: <d9ff3a7a-7c2e-80a2-7910-3cc1a530833e@reto-schneider.ch>
On 6/17/21 6:06 PM, Reto Schneider wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi all,
>
> On 17.06.21 16:19, Michael Walle wrote:
>> That is up to the maintainers, but sooner or later we will have to face
>> the problem regarding the duplicate IDs.
>
> A strongly worded statement by the maintainer(s) ("the Linux crowd")
> against ignoring the continuation codes might help (me) to put pressure
> on non-compliant manufacturers.
>
We saw few ID collisions even between flashes of the same manufacturer, macronix.
Reusing flash IDs without providing an extended ID field, or ignoring the
continuation codes is bad design, and I would avoid using such flash. But I won't
reject new flash additions solely because they have a wrong identification mechanism.
We'll cast an indirect public shame on the collisions by writing hackish code when
trying to differentiate between the flashes in software.
next prev parent reply other threads:[~2021-06-28 5:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 12:12 [PATCH v1] mtd: spi-nor: Add support for XM25QH64C Reto Schneider
2021-06-14 6:56 ` Michael Walle
2021-06-17 11:59 ` Reto Schneider
2021-06-17 14:19 ` Michael Walle
2021-06-17 15:06 ` Reto Schneider
2021-06-28 5:17 ` Tudor.Ambarus [this message]
2021-06-28 4:55 ` Tudor.Ambarus
2021-06-30 14:15 ` Michael Walle
2021-06-30 18:28 ` Tudor.Ambarus
2021-07-01 5:25 ` Tudor.Ambarus
2021-07-01 6:15 ` Michael Walle
2021-06-28 5:32 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9ea6f8-b8d1-cda8-e2c0-652adf957a90@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=code@reto-schneider.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=reto.schneider@husqvarnagroup.com \
--cc=richard@nod.at \
--cc=sr@denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).