linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "liwei (GF)" <liwei391@huawei.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Huacai Chen <chenhc@lemote.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: <linux-mips@vger.kernel.org>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<linux-kernel@vger.kernel.org>,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: No need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable()
Date: Tue, 15 Dec 2020 11:26:59 +0800	[thread overview]
Message-ID: <0aafd8a7-a9ec-524e-7279-d40dbf246375@huawei.com> (raw)
In-Reply-To: <1606299090-14013-1-git-send-email-yangtiezhu@loongson.cn>

Hi,

On 2020/11/25 18:11, Tiezhu Yang wrote:
> After commit 9cce844abf07 ("MIPS: CPU#0 is not hotpluggable"),

Why CPU#0 is not hotpluggable on MIPS? Does that unrealizable?

> c->hotpluggable is 0 for CPU 0 and it will not generate a control
> file in sysfs for this CPU:
> 
> [root@linux loongson]# cat /sys/devices/system/cpu/cpu0/online
> cat: /sys/devices/system/cpu/cpu0/online: No such file or directory
> [root@linux loongson]# echo 0 > /sys/devices/system/cpu/cpu0/online
> bash: /sys/devices/system/cpu/cpu0/online: Permission denied
> 
> So no need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable(),

missing cps_cpu_disable()?

Thanks,
Wei

> just remove them.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  arch/mips/cavium-octeon/smp.c | 3 ---
>  arch/mips/kernel/smp-bmips.c  | 3 ---
>  arch/mips/loongson64/smp.c    | 3 ---
>  3 files changed, 9 deletions(-)
> 
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index 076db9a..66ce552 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -290,9 +290,6 @@ static int octeon_cpu_disable(void)
>  {
>  	unsigned int cpu = smp_processor_id();
>  
> -	if (cpu == 0)
> -		return -EBUSY;
> -
>  	if (!octeon_bootloader_entry_addr)
>  		return -ENOTSUPP;
>  
> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c
> index 1dbfb5a..359b176 100644
> --- a/arch/mips/kernel/smp-bmips.c
> +++ b/arch/mips/kernel/smp-bmips.c
> @@ -362,9 +362,6 @@ static int bmips_cpu_disable(void)
>  {
>  	unsigned int cpu = smp_processor_id();
>  
> -	if (cpu == 0)
> -		return -EBUSY;
> -
>  	pr_info("SMP: CPU%d is offline\n", cpu);
>  
>  	set_cpu_online(cpu, false);
> diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c
> index aa0cd72..b8c1fc3 100644
> --- a/arch/mips/loongson64/smp.c
> +++ b/arch/mips/loongson64/smp.c
> @@ -544,9 +544,6 @@ static int loongson3_cpu_disable(void)
>  	unsigned long flags;
>  	unsigned int cpu = smp_processor_id();
>  
> -	if (cpu == 0)
> -		return -EBUSY;
> -
>  	set_cpu_online(cpu, false);
>  	calculate_cpu_foreign_map();
>  	local_irq_save(flags);
> 

  parent reply	other threads:[~2020-12-15  3:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 10:11 [PATCH] MIPS: No need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable() Tiezhu Yang
2020-11-25 17:06 ` Florian Fainelli
2020-11-27  9:32 ` Thomas Bogendoerfer
2020-12-15  3:26 ` liwei (GF) [this message]
2020-12-15  4:10   ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aafd8a7-a9ec-524e-7279-d40dbf246375@huawei.com \
    --to=liwei391@huawei.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chenhc@lemote.com \
    --cc=f.fainelli@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).