From: Chris Clayton <firstname.lastname@example.org> To: "吳昊澄 Ricky" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Cc: LKML <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Arnd Bergmann <email@example.com> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes Date: Tue, 4 Aug 2020 09:50:45 +0100 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 04/08/2020 09:08, 吳昊澄 Ricky wrote: >> -----Original Message----- >> From: firstname.lastname@example.org [mailto:email@example.com] >> Sent: Tuesday, August 04, 2020 3:49 PM >> To: 吳昊澄 Ricky >> Cc: Chris Clayton; LKML; firstname.lastname@example.org; email@example.com; Arnd >> Bergmann >> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on >> Intel NUC boxes >> >> On Tue, Aug 04, 2020 at 02:44:41AM +0000, 吳昊澄 Ricky wrote: >>> Hi Chris, >>> >>> rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN); >>> This register operation saved power under 1mA, so if do not care the 1mA >> power we can have a patch to remove it, make compatible with NUC6 >>> We tested others our card reader that remove it, we did not see any side effect >>> >>> Hi Greg k-h, >>> >>> Do you have any comments? >> >> comments on what? I don't know what you are responding to here, sorry. >> > Can we have a patch to kernel for NUC6? It may cause more power(1mA) but it will have more compatibility > Ricky, I don't understand why you want to completely remove the code that sets up the 1mA power saving. That code was there even before your patch (bede03a579b3b4a036003c4862cc1baa4ddc351f), so I assume it benefits some of the Realtek card readers. Before your patch however, rtsx_pci_init_ocp() was not called for the rts5229 reader, but the patch introduced an unconditional call to that function into rtsx_pci_init_hw(), which is run for the rts5229. That is what now disables the card reader. Now, I don't know whether other cards are affected, although I don't recall seeing any reported as I searched the kernel and ubuntu bugzillas for any analysis of the problem. I know this is not what the patch I sent does, but having thought about it more, seems to me that the simplest fix is to skip the new call to rtsx_pci_init_ocp() if the reader is an rts5229. If you agree, I can prepare a patch and send it to you. Whatever the solution is, it will also be needed in the stable kernels later than 5.0. Chris >> greg k-h >> >> ------Please consider the environment before printing this e-mail.
next prev parent reply index Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-02 19:48 Chris Clayton 2020-08-02 19:58 ` Chris Clayton 2020-08-03 3:01 ` 吳昊澄 Ricky 2020-08-03 5:27 ` Chris Clayton 2020-08-04 2:44 ` 吳昊澄 Ricky 2020-08-04 7:48 ` gregkh 2020-08-04 8:08 ` 吳昊澄 Ricky 2020-08-04 8:13 ` gregkh 2020-08-04 8:50 ` Chris Clayton [this message] 2020-08-04 10:46 ` 吳昊澄 Ricky 2020-08-04 11:51 ` Chris Clayton 2020-08-05 2:35 ` 吳昊澄 Ricky 2020-08-05 5:51 ` Chris Clayton 2020-08-05 12:48 ` Chris Clayton 2020-08-22 7:24 ` Chris Clayton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ firstname.lastname@example.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git